Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix Path deepcopy signature #6877
Conversation
mdboom
added the
needs_review
label
Aug 1, 2016
|
I don't think any of the tests failures were related--I restarted the failing Travis jobs to confirm. Can someone restart the AppVeyor job? |
tacaswell
added this to the
2.0.1 (next bug fix release)
milestone
Aug 2, 2016
|
https://docs.python.org/3.5/library/copy.html?highlight=__deepcopy__ <- fixed the link for you Do we need to do anything with memo? |
|
However, hold on this until I can fix another issue with the copy. I am not in position to do so at the moment. |
|
@tacaswell What link problem? |
|
Okay. I fixed the other issue of not being able to deecopy if the path had no codes. |
tacaswell
merged commit 3f7e675
into matplotlib:master
Aug 3, 2016
tacaswell
removed the
needs_review
label
Aug 3, 2016
tacaswell
added a commit
that referenced
this pull request
Aug 3, 2016
|
|
tacaswell |
b338a71
|
has2k1 commentedAug 1, 2016
Problem
Path.__deepcopy__does not accept a second(memo) parameter,so the common usage of the
deepcopyfunction fails.Solution
Add second parameter.