Prevent forced alpha in figureoptions. #6895

Merged
merged 1 commit into from Aug 4, 2016

Conversation

Projects
None yet
4 participants
Contributor

anntzer commented Aug 3, 2016

Forcing the alpha value sets it not only for the line color but also the
marker faces and edges (i.e., editing the alpha value of the markers
in the options editor had no effect). Instead, just remove any forced
alpha and use the alpha values that have been set in the editor.

A later idea may be to make alpha not override alpha values passed in
together with the color as quadruplets.

See discussion starting at #6383 (comment)

@anntzer anntzer Prevent forced alpha in figureoptions.
Forcing the alpha value sets it not only for the line color but also the
marker faces and edges (i.e., editing the alpha value of the markers
in the options editor had no effect).  Instead, just remove any forced
alpha and use the alpha values that have been set in the editor.

A later idea may be to make alpha not override alpha values passed in
together with the color as quadruplets.
24fb5c6

mdboom added the needs_review label Aug 3, 2016

QuLogic added the GUI/Qt label Aug 3, 2016

Owner

tacaswell commented Aug 4, 2016

This has the effect of over-ridding any previously supplied user input, but that is ok as they are in the editor (and the way it was is also throwing away user input), so merging.

@tacaswell tacaswell merged commit 2972f15 into matplotlib:master Aug 4, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 70.84%
Details

tacaswell removed the needs_review label Aug 4, 2016

@tacaswell tacaswell added a commit that referenced this pull request Aug 4, 2016

@tacaswell tacaswell Merge pull request #6895 from anntzer/prevent-forced-alpha-in-figureo…
…ptions

FIX: Prevent forced alpha in figureoptions.
5fb9017
Owner

tacaswell commented Aug 4, 2016

backported to v2.x as 5fb9017

anntzer deleted the anntzer:prevent-forced-alpha-in-figureoptions branch Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment