Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix read mode when loading cached AFM fonts #6898
Conversation
mdboom
added the
needs_review
label
Aug 3, 2016
zblz
referenced
this pull request
Aug 3, 2016
Merged
Proposed change to default log scale tick formatting #5161
|
Indeed, reading through afm.py, it looks like it expects all of the reads to return bytestrings given that it does comparisons against literal byte-strings. |
WeatherGod
merged commit f3b6c4e
into matplotlib:master
Aug 4, 2016
mdboom
removed the
needs_review
label
Aug 4, 2016
|
This piqued my interest a bit, and I noticed that we are inconsistent with how we are opening the AFM files. Grepping through reveals a few more non-binary open() calls. Would you like to fix those, too? |
|
actually, looks like that was the only one, although the one in font_manager.py could benefit from context manager. I'll backport just this. |
WeatherGod
added a commit
that referenced
this pull request
Aug 4, 2016
|
|
WeatherGod |
08e2520
|
|
Backported to v2.x via 08e2520. |
QuLogic
added this to the
2.0 (style change major release)
milestone
Aug 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zblz commentedAug 3, 2016
This fixes a typo to read cached AFM fonts as a byte string, as needed by the AFM class in
afm.py. This bug is triggered when testing PR #5161.cc: @mdboom