/matplotlib

Use edgecolor rather than linewidth to control edge display. #6904

Merged
merged 3 commits into from Aug 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
2 participants
@efiring @tacaswell
@efiring
Owner

efiring commented Aug 5, 2016 • edited

Closes #6844.
An rcParam['patch.force_edgecolor'] was added so that a default
edgecolor can be specified to be used always (as in classic mode),
or to be used only when a fillable object is not actually filled.
@efiring efiring Use edgecolor rather than linewidth to control edge display. 
An rcParam['patch.force_edgecolor'] was added so that a default
edgecolor can be specified to be used always (as in classic mode),
or to be used only when a fillable object is not actually filled.

All checks have failed

2 failing checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
05e4ed9

efiring added the needs_review label Aug 5, 2016

efiring added some commits Aug 5, 2016

@efiring efiring fix some test failures

Some checks were not successful

1 errored, 1 failing, and 1 pending checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage pending from Coveralls.io
Details
4ab8e14
@efiring efiring set facecolor before edgecolor, which may depend on facecolor

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.01%) to 70.875%
Details
69af0e7

efiring added this to the 2.0 (style change major release) milestone Aug 5, 2016

@efiring
Owner

efiring commented Aug 7, 2016

Appveyor failure is unrelated--seems to be some interior Appveyor glitch in the build process.

efiring referenced this pull request Aug 7, 2016

Closed

bar(..., linewidth=None) doesn't display bar edges with mpl2.0b3 #6894

@tacaswell tacaswell merged commit 36f1353 into matplotlib:master Aug 22, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 70.875%
Details

tacaswell removed the needs_review label Aug 22, 2016

@tacaswell tacaswell added a commit that referenced this pull request Aug 22, 2016

@tacaswell tacaswell Merge pull request #6904 from efiring/scatter_edgecolor 
MNT: Use edgecolor rather than linewidth to control edge display.
 7bf436c
@tacaswell
Owner

tacaswell commented Aug 22, 2016

backported to v2.x as 7bf436c

This was referenced Sep 23, 2016

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment