/matplotlib

Make sure nose is only imported when needed #6923

Merged
merged 1 commit into from Aug 13, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
  v2.0.0
6 participants
@astrofrog @jenshnielsen @Kojoley @tacaswell @mdboom @QuLogic
@astrofrog
Contributor

astrofrog commented Aug 8, 2016

This allows other functions/classes here to be used by pytest-based testing suites (e.g. pytest-mpl) without requiring nose to be installed.
@astrofrog astrofrog Make sure nose is only imported when needed

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 70.862%
Details
360b8c0

mdboom added the needs_review label Aug 8, 2016

@jenshnielsen
Owner

jenshnielsen commented Aug 8, 2016

👍 but probably need to coordinate with #6920

astrofrog referenced this pull request in matplotlib/pytest-mpl Aug 8, 2016

Closed

Remove dependency on nose package #28

@Kojoley
Member

Kojoley commented Aug 8, 2016

I have changed switch_backend in #6920 to not use nose at all.
@tacaswell
Owner

tacaswell commented Aug 13, 2016

I am going to merge and backport this to 2.x as #6920 needs a rebase anyway.

@tacaswell tacaswell merged commit 771707f into matplotlib:master Aug 13, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 70.862%
Details

tacaswell removed the needs_review label Aug 13, 2016

@tacaswell tacaswell added a commit that referenced this pull request Aug 13, 2016

@tacaswell tacaswell Merge pull request #6923 from astrofrog/nose-optional 
MNT: Make sure nose is only imported when needed
 48dedc4
@tacaswell
Owner

tacaswell commented Aug 13, 2016

backported to v2.x as 48dedc4

tacaswell added this to the 2.0 (style change major release) milestone Aug 13, 2016

@arafune arafune added a commit to arafune/matplotlib that referenced this pull request Aug 18, 2016

@arafune arafune Merge commit '48dedc481631f9b5d9a6f3e725212b68b1ab03ad' 
* commit '48dedc481631f9b5d9a6f3e725212b68b1ab03ad':
  Merge pull request #6923 from astrofrog/nose-optional
  Simplified loop in `Axes.bxp.to_vc`
 fb987ae

QuLogic added the Testing label Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment