Text box widget, take over of PR5375

[fariza]

Friendly take over of #5375

[fariza]

@tacaswell here is the new PR, I just discover a small bug

Traceback (most recent call last):
  File "/home/fede/workspace/matplotlib/lib/matplotlib/backends/backend_gtk3.py", line 249, in key_press_event
    FigureCanvasBase.key_press_event(self, key, guiEvent=event)
  File "/home/fede/workspace/matplotlib/lib/matplotlib/backend_bases.py", line 1839, in key_press_event
    self.callbacks.process(s, event)
  File "/home/fede/workspace/matplotlib/lib/matplotlib/cbook.py", line 541, in process
    proxy(*args, **kwargs)
  File "/home/fede/workspace/matplotlib/lib/matplotlib/cbook.py", line 408, in __call__
    return mtd(*args, **kwargs)
  File "/home/fede/workspace/matplotlib/lib/matplotlib/backend_bases.py", line 2685, in key_press
    key_press_handler(event, self.canvas, self.canvas.toolbar)
  File "/home/fede/workspace/matplotlib/lib/matplotlib/backend_bases.py", line 2609, in key_press_handler
    if not (event.key in all):
TypeError: argument of type 'builtin_function_or_method' is not iterable

I will try to fix it next week

@Nodraak can you submit a PR against this one?

@smithsp can you create a PR from your branch https://github.com/smithsp/matplotlib/tree/text-box-widget to mine https://github.com/fariza/matplotlib/tree/text-box-widget

[Nodraak]

@fariza Here you go :)

I just discover a small bug

I'm not sure if all is supposed to be all_keys ... Looks like a silly typo

[QuadmasterXLII]

Hi! Thanks for the friendly takeover -- sorry for dropping off the face of the earth there

[fariza]

@Nodraak for the time being I didn't take the set_facecolor change because I wasn't able to reproduce the problem.

[fariza]

@tacaswell I don't think the failure is related.

[jenshnielsen]

I merged #7006 which should fix the docs build error on Travis

[fariza]

@jenshnielsen any idea on the appveyor fail?

[smithsp]

@fariza
Does https://ci.appveyor.com/project/mdboom/matplotlib/build/1.0.2460/job/xe3avci96c77qirw#L1609
not explain the failure?

[fariza]

@smithsp maybe I'm lost in the logs, but I don't see a relation between this PR changes and the failure

[smithsp]

@fariza
I agree that this PR is not the cause of appveyor failure. I guess that is why you pinged @jenshnielsen

[jenshnielsen]

That is probably fixed by #7011

[fariza]

In that case, that's all from my side.
Any other question/suggestion/changes?

Ready to merge

[jenshnielsen]

Power cycling again

[tacaswell]

Thanks everyone for getting this across the finish line!

[QuadmasterXLII]

Thank you so much for your help!

On Sat, Sep 3, 2016 at 4:09 PM, Thomas A Caswell notifications@github.com
wrote:

Thanks everyone for getting this across the finish line!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6988 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGgnAXEV-VCZMSyXwpatin0GEH-X5vgPks5qmdQUgaJpZM4JusI0
.