/matplotlib

DOC change axhspan to numpydoc format #7037

Merged
merged 2 commits into from Sep 9, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
  v2.0.0
5 participants
@maluethi @NelleV @QuLogic @tacaswell @mdboom
@maluethi
Contributor

maluethi commented Sep 5, 2016

Greetings from Rivo and Matthias at ASPP summer school.

@NelleV
maluethi DOC change axhspan to numpydoc format

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.002%) to 70.37%
Details
63f46e9

mdboom added the needs_review label Sep 5, 2016

@NelleV
Contributor

NelleV commented Sep 5, 2016

This looks good! Thanks for the patch.
Cheers,
N
@NelleV
Contributor

NelleV commented Sep 5, 2016

@tacaswell This PR is ready for review (and merge).

QuLogic added the Documentation label Sep 6, 2016

@QuLogic QuLogic and 2 others commented on an outdated diff Sep 6, 2016

View full outdated diff
lib/matplotlib/axes/_axes.py
- %(Polygon)s
@QuLogic

QuLogic Sep 6, 2016

Member

why remove this?

@NelleV

NelleV Sep 6, 2016

Contributor

It's been moved to the section "Other parameters".

@QuLogic

QuLogic Sep 6, 2016

Member

Only the general line (i.e., kwargs), but not this substitution of all the keyword arguments.

@maluethi

maluethi Sep 7, 2016

Contributor

Unfortunately the list reference got lost during the conversion process. I fixed this in the new commit.
@QuLogic
Member

QuLogic commented Sep 6, 2016

This PR should probably be coordinated with #7039 to get consistent prose.

QuLogic referenced this pull request Sep 6, 2016

Closed

DOC changed documentation for axvspan to numpydoc format @NelleV #7039

@QuLogic
Member

QuLogic commented Sep 6, 2016

Your commit is currently attributed to "maluethi". It is your choice to use a real name or not, of course, but I'm just making a note of it in case it was unintended.
@maluethi maluethi DOC Add a Polygon reference under other parameters which was lost dur… 
…ing conversion to numpy doc.

Some checks were not successful

2 failing and 1 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.006%) to 70.362%
Details
97a0e65
@NelleV
Contributor

NelleV commented Sep 7, 2016

The failing test seem unrelated so I think we are good to merge (thought it be good to relaunch the failing test on travis to make sure).
N
@QuLogic
Member

QuLogic commented Sep 7, 2016

The two commits are attributed to two different names and two different email address, though they seem to refer to the same person; please confirm that is what you really want to do.
@maluethi
Contributor

maluethi commented Sep 7, 2016

@QuLogic: This is fine by me.

@tacaswell tacaswell merged commit 7aa1db0 into matplotlib:master Sep 9, 2016
1 of 3 checks passed

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage decreased (-0.006%) to 70.362%
Details

tacaswell removed the needs_review label Sep 9, 2016

@tacaswell tacaswell added a commit that referenced this pull request Sep 9, 2016

@tacaswell tacaswell Merge pull request #7037 from maluethi/doc 
DOC: change axhspan to numpydoc format
 0234978
@tacaswell
Owner

tacaswell commented Sep 9, 2016

backported to v2.x as 0234978

Thanks for your work!

QuLogic added this to the 2.0 (style change major release) milestone Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment