/matplotlib

FIX: ticks filtered by Axis, not in Tick.draw #7042

Merged
merged 2 commits into from Sep 6, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Release critical
Projects
None yet
Milestone
  v2.0.0
3 participants
@tacaswell @anntzer @efiring
@tacaswell
Owner

tacaswell commented Sep 5, 2016

Replaces #6647

tacaswell added this to the 2.0 (style change major release) milestone Sep 5, 2016

tacaswell added the needs_review label Sep 5, 2016

anntzer and others added some commits Jun 27, 2016

@anntzer @tacaswell anntzer Assume that tickers respect view limits. 
Tickers may return positions epsilon-outside of the view limits and we
don't want to drop them.

The filtering of the ticks is done in the `_update_ticks` method of
`mpl.axis.Axis` which adds a 0.5 px or pt extension onto the view limit
to ensure that ticks on the edge are drawn.
 bd05136
@tacaswell tacaswell TST: update tests to account for additional ticks

Some checks were not successful

1 errored and 2 successful checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.008%) to 70.363%
Details
1c2281b

tacaswell changed the title from Assume ticker respects viewlims to ticks filtered by Axis, not in Tick.draw Sep 5, 2016

tacaswell changed the title from ticks filtered by Axis, not in Tick.draw to FIX: ticks filtered by Axis, not in Tick.draw Sep 5, 2016

@tacaswell
Owner

tacaswell commented Sep 5, 2016

@anntzer Corrected the tests and re-worded your commit message a bit to add a note about where the tick-in-view-limit filtering is actually accruing.

tacaswell added the Release critical label Sep 5, 2016

@anntzer
Contributor

anntzer commented Sep 5, 2016

Thanks for taking over, I've been a bit busy recently.

@efiring efiring merged commit acdf412 into matplotlib:master Sep 6, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 70.363%
Details

efiring removed the needs_review label Sep 6, 2016

@efiring
Owner

efiring commented Sep 6, 2016

I merged because I didn't see any point in waiting for Appveyor for this one; Travis passed.

@efiring efiring added a commit that referenced this pull request Sep 6, 2016

@efiring efiring Merge pull request #7042 from tacaswell/assume-ticker-respects-viewlims 
FIX: ticks filtered by Axis, not in Tick.draw
 9bc745c
@efiring
Owner

efiring commented Sep 6, 2016

Pushed to v2.x as 9bc745c.

efiring referenced this pull request Sep 6, 2016

Closed

Edge ticks sometimes disappear #6641

tacaswell deleted the tacaswell:assume-ticker-respects-viewlims branch Sep 6, 2016

This was referenced Sep 6, 2016

Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment