/matplotlib

FIX: remove unused variable #7048

Merged
merged 1 commit into from Sep 7, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
5 participants
@keszybz @NelleV @tacaswell @mdboom @QuLogic
@keszybz
Contributor

keszybz commented Sep 6, 2016

No description provided.

mdboom added the needs_review label Sep 6, 2016

@keszybz
Contributor

keszybz commented Sep 6, 2016

@NelleV
@NelleV
Contributor

NelleV commented Sep 6, 2016

LGTM 👍 for merging.
@tacaswell
Owner

tacaswell commented Sep 6, 2016

For the record, the code that used this variable was removed in f60aa88

tacaswell added this to the 2.1 (next point release) milestone Sep 6, 2016

@tacaswell
Owner

tacaswell commented Sep 6, 2016

Can who ever merges this please make sure the note in my last comment makes it in to the merge commit message?
@keszybz keszybz FIX: remove unused variable 
For the record, the code that used this variable was removed in
f60aa88.

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.002%) to 70.363%
Details
99384ce
@keszybz
Contributor

keszybz commented Sep 6, 2016

Repushed with amended commit message.
@NelleV
Contributor

NelleV commented Sep 7, 2016

@tacaswell I think this is ready for merge (I can't merge myself anymore).
The appveyor's build failure seems unrelated.

@QuLogic QuLogic merged commit f16a2c9 into matplotlib:master Sep 7, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 70.363%
Details

QuLogic removed the needs_review label Sep 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment