FIX: testings.nose was not installed #7055

Merged
merged 1 commit into from Sep 8, 2016

Conversation

Projects
None yet
7 participants
Contributor

NelleV commented Sep 7, 2016

I am not sure how the tests work on any platform right now… testing.nose was not installed, so the tests could not run.

mdboom added the needs_review label Sep 7, 2016

@NelleV NelleV FIX update setupext.py with testing.nose
Note: the tests cannot run on most platforms
2af2412
Member

Kojoley commented Sep 7, 2016

Thanks for fixing my mistake!

Contributor

NelleV commented Sep 7, 2016

My humble opinion is that this shows an underlying problem on the way travis runs the tests (and in general how brittle matplotlib's tests are). At some point, it might be worth doing major reorganization of the repository to have it follow a more traditional organization.
I just hope this hasn't been around for too long, as this show that people don't run the tests on their laptop :)

Owner

tacaswell commented Sep 7, 2016

The tests will run correctly if you install via python setup.py develop / pip install -e . (which is how I do it).

Contributor

NelleV commented Sep 8, 2016

appveyor seems unhappy for a font problem. That seems quite unrelated to this PR. Is there a way to relaunch it?

Contributor

afvincent commented Sep 8, 2016

@NelleV Closing the PR and reopening it usually does the trick.

afvincent closed this Sep 8, 2016

mdboom removed the needs_review label Sep 8, 2016

afvincent reopened this Sep 8, 2016

mdboom added the needs_review label Sep 8, 2016

Owner

jenshnielsen commented Sep 8, 2016

The appveyor issue is unrelated and hopefully fixed by #7063

@jenshnielsen jenshnielsen merged commit 67a5170 into matplotlib:master Sep 8, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 70.36%
Details
Contributor

NelleV commented Sep 8, 2016

@jenshnielsen I saw the PR and I'll wait until it is merged to rebase.

Contributor

NelleV commented Sep 8, 2016

I guess I won't rebase! Thanks!

NelleV deleted the unknown repository branch Sep 8, 2016

Owner

jenshnielsen commented Sep 8, 2016

I didn't want to hold back your work since this is a serious bug and the failure clearly unrelated

QuLogic added this to the 2.1 (next point release) milestone Sep 8, 2016

QuLogic added the Testing label Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment