Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
FIX: testings.nose was not installed #7055
Conversation
mdboom
added the
needs_review
label
Sep 7, 2016
|
Thanks for fixing my mistake! |
|
My humble opinion is that this shows an underlying problem on the way travis runs the tests (and in general how brittle matplotlib's tests are). At some point, it might be worth doing major reorganization of the repository to have it follow a more traditional organization. |
|
The tests will run correctly if you install via |
|
appveyor seems unhappy for a font problem. That seems quite unrelated to this PR. Is there a way to relaunch it? |
|
@NelleV Closing the PR and reopening it usually does the trick. |
afvincent
closed this
Sep 8, 2016
mdboom
removed the
needs_review
label
Sep 8, 2016
afvincent
reopened this
Sep 8, 2016
mdboom
added the
needs_review
label
Sep 8, 2016
|
The appveyor issue is unrelated and hopefully fixed by #7063 |
jenshnielsen
merged commit 67a5170
into matplotlib:master
Sep 8, 2016
jenshnielsen
removed the
needs_review
label
Sep 8, 2016
|
@jenshnielsen I saw the PR and I'll wait until it is merged to rebase. |
|
I guess I won't rebase! Thanks! |
NelleV
deleted the
unknown repository branch
Sep 8, 2016
|
I didn't want to hold back your work since this is a serious bug and the failure clearly unrelated |
NelleV commentedSep 7, 2016
I am not sure how the tests work on any platform right now… testing.nose was not installed, so the tests could not run.