Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
FIX: Removed financial demos that stalled because of yahoo requests #7057
Conversation
mdboom
added the
needs_review
label
Sep 7, 2016
|
The examples are being build on travis (as late as 6 hours ago https://travis-ci.org/matplotlib/matplotlib/builds/158107836) so I think this is a temporary outage. I would suggest just disabling them from running as parts of the docs build as suggested in #7049 |
NelleV
referenced
this pull request
Sep 7, 2016
Merged
Documentated dependencies to the doc and remove unecessary dependencies. #7049
|
@jenshnielsen I think we should remove them:
|
|
|
It may be that the finance module is already deprecated but we can't remove it unless we want lots of complaints from users that are still depending on it. I am just suggesting that we:
|
|
I think the data used in the examples can be saved to mpl repository and used to 'proxify' urllib requests. It can also be used in the tests for financial module |
Kojoley
closed this
Sep 7, 2016
mdboom
removed the
needs_review
label
Sep 7, 2016
|
Oh sorry for closing. This was a mistake. |
Kojoley
reopened this
Sep 7, 2016
mdboom
added the
needs_review
label
Sep 7, 2016
|
Why not generate totally fake data instead, would this make a difference for the example ? |
|
I agree that it's not a good use of time to do any work on these examples to fix the data loading then I would rather delete them, I just suggest that they should be deleted when they are moved with the finance code to their own repository. Then if anyone should feel like improving the code and or the examples they can do so in that repository independent of matplotlib. |
There is |
|
I will try to get around to creating a mpl_finance package asap that way we can delete the examples right away and perhaps even the finace module in time for 2.0 |
tacaswell
added this to the
2.0 (style change major release)
milestone
Sep 7, 2016
|
We probably should shim out mpl.finance to import from the new package and raise an exception with instructions of what to install to fix it. |
|
To keep things moving for @NelleV and company I am going to merge this and then immediantly open a PR to revert the merge. I think this unblock current progress and make sure we do not (will make it less likely) that these fall through the cracks. |
|
Just waiting for the docs to finish on travis to make sure we do not have an explicit reference to any of these. |
|
There seems to be a hard-coded list someplace
|
|
Minimal mpl_finance package up at https://github.com/matplotlib/mpl_finance |
tacaswell
merged commit dcab32b
into matplotlib:master
Sep 8, 2016
tacaswell
removed the
needs_review
label
Sep 8, 2016
tacaswell
added a commit
that referenced
this pull request
Sep 8, 2016
|
|
tacaswell |
b152ff9
|
|
backported to v2.x as b152ff9 |
|
\o/ Thanks! |
rougier commentedSep 7, 2016
•
edited
This PR removes 5 examples from the documenation because they are relying on financial data from yahoo that do not seem to be available anymore. see #7049