/matplotlib

Minor animation fixes #7058

Merged
merged 2 commits into from Sep 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Animation
Projects
None yet
Milestone
  v2.0.0
6 participants
@dopplershift @tacaswell @WeatherGod @Kojoley @mdboom @QuLogic
@dopplershift
Contributor

dopplershift commented Sep 7, 2016

  • Fixes #6964 (error in docstring)
  • Fixes #6965 (use get_figure() instead of .axes.figure)

mdboom added the needs_review label Sep 7, 2016

dopplershift added the Animation label Sep 7, 2016

dopplershift added this to the 2.1 (next point release) milestone Sep 7, 2016

@tacaswell
Owner

tacaswell commented Sep 7, 2016

These look like bug-fixes, can this be backported to v2.x?
@WeatherGod
Member

WeatherGod commented Sep 7, 2016

Looks good to me. Do we want this backported anywhere?

@Kojoley Kojoley commented on an outdated diff Sep 7, 2016

View full outdated diff
lib/matplotlib/animation.py
@@ -1205,8 +1205,8 @@ def _init_draw(self):
artist.set_visible(False)
artist.set_animated(self._blit)
# Assemble a list of unique axes that need flushing
@Kojoley

Kojoley Sep 7, 2016

Member

I think the comment needs correction
@dopplershift
Contributor

dopplershift commented Sep 7, 2016

I don't see why it couldn't be backported. Would it be better to make this PR against the v2.x branch?
@dopplershift
Contributor

dopplershift commented Sep 7, 2016

Well, I fixed the comments, but accidentally pushed to master. My bad guys.

dopplershift added some commits Sep 7, 2016

@dopplershift dopplershift BUG: Use get_figure() rather than attribute. (Fixes #6965) 
This allows artists without a .axes attribute to work in animations.
This commit was signed with a verified signature.
@dopplershift dopplershift Ryan May
GPG key ID: 33BF97C62E8ACC62 Learn about signing commits
51f09dd
@dopplershift dopplershift BUG: Fix error in ArtistAnimation docstring (Fixes #6964) 
The parameter is artists, not frame_info.
This commit was signed with a verified signature.
@dopplershift dopplershift Ryan May
GPG key ID: 33BF97C62E8ACC62 Learn about signing commits

Some checks were not successful

1 failing and 1 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
coverage/coveralls — First build on master at 70.362%
Details
6962dee

@tacaswell tacaswell merged commit cddcfbe into matplotlib:master Sep 8, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls First build on master at 70.362%
Details

@tacaswell tacaswell modified the milestone: 2.0.1 (next bug fix release), 2.1 (next point release) Sep 8, 2016

tacaswell removed the needs_review label Sep 8, 2016

@tacaswell tacaswell added a commit that referenced this pull request Sep 8, 2016

@dopplershift @tacaswell dopplershift + tacaswell Merge pull request #7058 from dopplershift/anim-fixes 
FIX: Minor animation fixes

Also backport 4cb15ef which was
accidentally pushed to master
 2a33d6e
@tacaswell
Owner

tacaswell commented Sep 8, 2016

backported to v2.x as 2a33d6e

Also grabbed the commit pushed to master.

dopplershift deleted the dopplershift:anim-fixes branch Sep 20, 2016

@QuLogic QuLogic modified the milestone: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016

QuLogic referenced this pull request Dec 7, 2016

Merged

Don't work out packages to install if user requests information from setup.p #7538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment