label_outer() should remove inner minor ticks too. #7077

Merged
merged 1 commit into from Sep 9, 2016

Conversation

Projects
None yet
3 participants
Contributor

anntzer commented Sep 9, 2016

Minimal example:

fig, axs = plt.subplots(2, 2, sharex=True, sharey=True)
axs[0, 0].set(xscale="log", yscale="log", xlim=(1, 10))
for ax in axs: ax.label_outer()

Also, do not switch back on visibility of outer offset text if it was
not visible before.

@anntzer anntzer label_outer() should remove inner minor ticks too.
Minimal example:

    fig, axs = plt.subplots(2, 2, sharex=True, sharey=True)
    axs[0, 0].set(xscale="log", yscale="log", xlim=(1, 10))
    for ax in axs: ax.label_outer()

Also, do not switch back on visibility of outer offset text if it was
not visible before.
4f6320e

mdboom added the needs_review label Sep 9, 2016

Owner

tacaswell commented Sep 9, 2016

Didn't we already do this?

tacaswell added this to the 2.1 (next point release) milestone Sep 9, 2016

Contributor

anntzer commented Sep 9, 2016

Nope (see example; should also be clear from the earlier implementation). Probably not noticed earlier because this only affects log-scale plots by default (linear scales default to no minor grid).

Owner

tacaswell commented Sep 9, 2016

👍 Now understand

@tacaswell tacaswell merged commit e92dc56 into matplotlib:master Sep 9, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 70.362%
Details

tacaswell removed the needs_review label Sep 9, 2016

anntzer deleted the anntzer:label-outer-minor-ticks branch Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment