/matplotlib

TST: Restore broken `test_use14corefonts` #7094

Merged
merged 1 commit into from Sep 12, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
4 participants
@Kojoley @jenshnielsen @mdboom @QuLogic
@Kojoley
Member

Kojoley commented Sep 12, 2016

History:
@Kojoley Kojoley TST: Restore broken `test_use14corefonts` 
History:

 - c0fcab4 - disabled on travis
 - f4adec7 - commented out
 - ff227d3 - enabled, but chopped

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.07%) to 70.436%
Details
4ac3300

mdboom added the needs_review label Sep 12, 2016

@jenshnielsen
Owner

jenshnielsen commented Sep 12, 2016

👍 IMHO it's a bug that the previous code did not raise an error. It's basically comparing a valid pdf to a empty image as far as I can see
@Kojoley
Member

Kojoley commented Sep 12, 2016

The weak place is for fignum, baseline in zip(plt.get_fignums(), self._baseline_images):. zip shrinks lists to the size of the smallest. I am working on a refactor of image_comparison decorator and the issue come up on several tests, but this one was the most surprising.
@jenshnielsen
Owner

jenshnielsen commented Sep 12, 2016

Thanks @Kojoley good to know

@jenshnielsen jenshnielsen merged commit 4f559a9 into matplotlib:master Sep 12, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 70.436%
Details

jenshnielsen removed the needs_review label Sep 12, 2016

QuLogic added this to the 2.1 (next point release) milestone Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment