Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added `-j` shortcut for `--processes=` #7362
Conversation
|
I am totally in favor of |
NelleV
approved these changes
Oct 30, 2016
At some point we will have to refactor a bit this code, but for now this looks good.
| if __name__ == '__main__': | ||
| from matplotlib import default_test_modules, test | ||
| extra_args = [] | ||
| - if '--no-pep8' in sys.argv: | ||
| + parser = argparse.ArgumentParser() | ||
| + parser.add_argument('--no-pep8', action="store_true") |
efiring
Oct 30, 2016
Owner
It's certainly confusing. I think the idea is that '--pep8' means do only PEP8 testing, '--no-pep8' means do everything except PEP8 testing, and leaving both out means test everything including PEP8.
When using argparse, it would be good to add 'help' kwargs to each add_argument call.
|
I suppose argparse will interfere with nose on |
|
Haven't looked at the PR itself but in any case you can prevent argparse from adding a |
|
Sure. Added it |
|
This seems to have broken the See https://docs.python.org/3/library/argparse.html#nargs for |
tacaswell
added this to the
2.0.1 (next bug fix release)
milestone
Nov 8, 2016
|
milestoned as 2.0.1, but if the backport is at all hard, lets not bother. |
|
Latest commit should fix passthrough flags like |
tacaswell
changed the title from
Added `-j` shortcut for `--processes=` to [MRG+1] Added `-j` shortcut for `--processes=`
Nov 8, 2016
bcongdon
added some commits
Oct 30, 2016
NelleV
merged commit 3e89069
into matplotlib:master
Nov 8, 2016
|
@tacaswell This does not apply cleanly on v2.x. I don't think it is worth bothering with this patch for 2.0. What do you think? |
|
I'll answer: No, just leave it in master. |
bcongdon commentedOct 30, 2016
Addresses #7361.
The argv parsing is a bit naive, but I'm not sure what matplotlib's opinion on
getoptorargparseis.