Moved python files from doc/pyplots to examples folder #7398

Merged
merged 4 commits into from Nov 5, 2016

Conversation

Projects
None yet
5 participants
Contributor

wgma00 commented Nov 3, 2016

Completed the first two changes specified in #7390 . When I was looking through the pyplots files with grep I didn't spot any places where the stdlib random module was used in stead of the numpy.random module.

@wgma00 wgma00 moved python files from doc/pyplots to examples folder
updated the dynamic links for doc/pyplots to examples/pyplots

fixed random state for reproducibility in pyplot examples
7d64c41

tacaswell added this to the 2.0.1 (next bug fix release) milestone Nov 3, 2016

tacaswell changed the title from Moved python files from doc/pyplots to examples folder to [MRG+1] Moved python files from doc/pyplots to examples folder Nov 3, 2016

@tacaswell

modulo the docs building cleanly on travis

Contributor

NelleV commented Nov 4, 2016

That's great!
Thank you for doing this work.

NelleV changed the title from [MRG+1] Moved python files from doc/pyplots to examples folder to [MRG+2] Moved python files from doc/pyplots to examples folder Nov 4, 2016

@NelleV

NelleV approved these changes Nov 4, 2016

@@ -310,7 +310,7 @@ git. Please also add a line to the README in doc/pyplots for any additional
requirements necessary to generate a new figure. Once these steps have been
taken, these figures can be included in the usual way::
- .. plot:: pyplots/tex_unicode_demo.py
+ .. plot:: mpl_examples/pyplots/tex_unicode_demo.py
@QuLogic

QuLogic Nov 4, 2016

Member

I wonder if this and the section above is relevant any more? I don't see either README or make.py in the original doc/pyplots.

Contributor

NelleV commented Nov 4, 2016

The failing tests are pep8 related error, which we probably don't want to fix in this PR…
If we merge, what's going to happen? How are the pep8 tests ran?

Member

QuLogic commented Nov 4, 2016

You can add those files to the list near the end of lib/matplotlib/tests/test_coding_standards.py to ignore the pep8 warnings for now.

@wgma00 wgma00 added examples from pyplots to ignore list for pep8 coding standards
fixed typo from previous commit; redirected to wrong file path
0543f77
Owner

efiring commented Nov 5, 2016

Strangely, the pep8 checker doesn't ignore the excluded files, it checks to make sure they need to be excluded!

ValueError: Some exclude patterns were unnecessary as the files they pointed to either passed the PEP8 tests or do not point to a file:
  */pyplots/pyplot_scales.py
  */pyplots/pyplot_text.py
  */pyplots/pyplot_three.py
  */pyplots/whats_new_99_mplot3d.py
Contributor

NelleV commented Nov 5, 2016

The strategy implemented on #7403 which runs flake8 on diffs fixes the issue we have on this PR.

Currently, there is a test that ensures that blacklisted files need to be blacklisted. Hence the new failure.

@wgma00 wgma00 Merge pull request #1 from NelleV/wgma00_master
FIX pep8 failed as some files are pep8 compliant
ce661b0

@NelleV NelleV merged commit 6709b59 into matplotlib:master Nov 5, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 61.824%
Details

@NelleV NelleV added a commit that referenced this pull request Nov 5, 2016

@NelleV NelleV Merge pull request #7398 from wgma00/master
Moved python files from doc/pyplots to examples folder
263e675
Contributor

NelleV commented Nov 5, 2016

Thanks @wgma00 for the patch!

Cherry-pick in 2.0 with 263e675

QuLogic changed the title from [MRG+2] Moved python files from doc/pyplots to examples folder to Moved python files from doc/pyplots to examples folder Nov 5, 2016

Owner

tacaswell commented Nov 9, 2016

Complaining that an excluded file passes is a feature of the system to (slowly) ratchet our way to PEP8 compliance (so we do not accidentally fix a file and then break it again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment