Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Moved python files from doc/pyplots to examples folder #7398
Conversation
tacaswell
added this to the
2.0.1 (next bug fix release)
milestone
Nov 3, 2016
tacaswell
added the
Documentation
label
Nov 3, 2016
tacaswell
changed the title from
Moved python files from doc/pyplots to examples folder to [MRG+1] Moved python files from doc/pyplots to examples folder
Nov 3, 2016
|
That's great! |
NelleV
changed the title from
[MRG+1] Moved python files from doc/pyplots to examples folder to [MRG+2] Moved python files from doc/pyplots to examples folder
Nov 4, 2016
| @@ -310,7 +310,7 @@ git. Please also add a line to the README in doc/pyplots for any additional | ||
| requirements necessary to generate a new figure. Once these steps have been | ||
| taken, these figures can be included in the usual way:: | ||
| - .. plot:: pyplots/tex_unicode_demo.py | ||
| + .. plot:: mpl_examples/pyplots/tex_unicode_demo.py |
QuLogic
Nov 4, 2016
Member
I wonder if this and the section above is relevant any more? I don't see either README or make.py in the original doc/pyplots.
|
The failing tests are pep8 related error, which we probably don't want to fix in this PR… |
|
You can add those files to the list near the end of |
|
Strangely, the pep8 checker doesn't ignore the excluded files, it checks to make sure they need to be excluded!
|
|
The strategy implemented on #7403 which runs flake8 on diffs fixes the issue we have on this PR. Currently, there is a test that ensures that blacklisted files need to be blacklisted. Hence the new failure. |
NelleV
merged commit 6709b59
into matplotlib:master
Nov 5, 2016
NelleV
added a commit
that referenced
this pull request
Nov 5, 2016
|
|
NelleV |
263e675
|
QuLogic
changed the title from
[MRG+2] Moved python files from doc/pyplots to examples folder to Moved python files from doc/pyplots to examples folder
Nov 5, 2016
This was referenced Nov 5, 2016
|
Complaining that an excluded file passes is a feature of the system to (slowly) ratchet our way to PEP8 compliance (so we do not accidentally fix a file and then break it again). |
wgma00 commentedNov 3, 2016
Completed the first two changes specified in #7390 . When I was looking through the
pyplotsfiles with grep I didn't spot any places where the stdlibrandommodule was used in stead of thenumpy.randommodule.