Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Clarify wspace/hspace in documentation/comments #7399
Conversation
NelleV
changed the title from
Clarify wspace/hspace in documentation/comments to [MRG+1] Clarify wspace/hspace in documentation/comments
Nov 4, 2016
NelleV
approved these changes
Nov 4, 2016
Thanks for the patch!
This looks good. I have a minor nitpick, we can merge as is.
| @@ -182,10 +182,12 @@ def __init__(self, left=None, bottom=None, right=None, top=None, | ||
| The top of the subplots of the figure | ||
| *wspace* : 0.2 |
NelleV
Nov 4, 2016
Contributor
Do you mind removing the * around the keyword? We don't need them anymore.
stilley2
Nov 4, 2016
•
Contributor
Just for wspace and hspace? The * seem to be ubiquitous. I guess my question is, how far should I go with this?
QuLogic
Nov 4, 2016
Member
They're from a time before numpydoc; since numpydoc formats parameters in bold anyway, these have been made redundant. Just no-one's gone through to fix them yet.
stilley2
Nov 4, 2016
Contributor
Gotcha. Alright I went through and removed them in a bunch of places in that file. I figured while I was there I wouldn't limit myself to just one class.
|
Thanks! |
|
No problem. Feels good to contribute. I make heavy use of matplotlib. |
NelleV
merged commit bdf2146
into matplotlib:master
Nov 4, 2016
QuLogic
added this to the
2.1 (next point release)
milestone
Nov 7, 2016
QuLogic
added the
Documentation
label
Nov 7, 2016
QuLogic
changed the title from
[MRG+1] Clarify wspace/hspace in documentation/comments to Clarify wspace/hspace in documentation/comments
Nov 7, 2016
|
Thanks @stilley2! Congratulations on your first PR into mpl |
tacaswell
added a commit
that referenced
this pull request
Nov 8, 2016
|
|
NelleV + tacaswell |
3d3b8d2
|
|
backported to v2.x as 3d3b8d2 In general, I think all of the documentation changes should be backported. |
stilley2 commentedNov 4, 2016
Addresses #6939