FIX: search for tkinter first in builtins #7433

Merged
merged 1 commit into from Nov 9, 2016

Conversation

Projects
None yet
4 participants
Contributor

matthew-brett commented Nov 9, 2016

Python compiled from Python.org source builds the tkinter module as a
built-in module, not an external module, as is the case for the packaged
builds of Debian etc:

>>> Tkinter.tkinter
<module '_tkinter' (built-in)>

This breaks the MPL algorithm for searching for tkinter symbols, which
loaded the external module .so file to get the symbols.

Try searching in the main program namespace for the tkinter symbols,
before looking for the extermal module .so file.

Thanks to github user ettaka for reporting : see
#7428

@matthew-brett matthew-brett FIX: search for tkinter first in builtins
Python compiled from Python.org source builds the tkinter module as a
built-in module, not an external module, as is the case for the packaged
builds of Debian etc:

    >>> Tkinter.tkinter
    <module '_tkinter' (built-in)>

This breaks the MPL algorithm for searching for tkinter symbols, which
loaded the external module .so file to get the symbols.

Try searching in the main program namespace for the tkinter symbols,
before looking for the extermal module .so file.

Thanks to github user ettaka for reporting : see
#7428
b4cc9cc

QuLogic added the GUI/tk label Nov 9, 2016

tacaswell changed the title from FIX: search for tkinter first in builtins to [MRG+1] FIX: search for tkinter first in builtins Nov 9, 2016

@NelleV NelleV merged commit 10f1522 into matplotlib:master Nov 9, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 61.832%
Details

@NelleV NelleV added a commit that referenced this pull request Nov 9, 2016

@NelleV NelleV Merge pull request #7433 from matthew-brett/master
FIX: search for tkinter first in builtins
033c3f2
Contributor

NelleV commented Nov 9, 2016

Backported as 033c3f2

Thanks @matthew-brett !

QuLogic changed the title from [MRG+1] FIX: search for tkinter first in builtins to FIX: search for tkinter first in builtins Nov 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment