Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
TST: Enable pytest-xdist #7468
Conversation
Kojoley
added the
Testing
label
Nov 16, 2016
Kojoley
added this to the
2.1 (next point release)
milestone
Nov 16, 2016
| + # https://github.com/pytest-dev/pytest/issues/920 | ||
| + # https://github.com/pytest-dev/pytest/issues/1075 | ||
| + export PYTHONHASHSEED=$(shuf -i 1-4294967295 -n 1) | ||
| + echo PYTHONHASHSEED=$PYTHONHASHSEED |
tacaswell
Nov 17, 2016
Owner
Aren't the tests that really care about this run in a shell-call with their own seeds set?
Kojoley
Nov 17, 2016
Member
Well, I have find out that xdist collection problem is triggered by test_mathtext.py, but I do not know what exactly, maybe globals() injection magic or something else. I think the best option for us is to rewrite test_mathtext to pytest fixtures and forget about this xdist issue.
QuLogic
Nov 18, 2016
Member
Hmm, that definitely is weird; is there a way to parametrize the fileename passed to the image_comparison decorator?
|
It still looks longer, the nose version it matches is the one for coverage which does not use parallelism. Am I confused? |
|
Oh, I wasn't looking at the parallelism, just that it wasn't exceptionally slow. |
|
We do not run all the tests with nose. |
|
Also the slowdown may be related to the problem described here pytest-dev/pytest-xdist#18 |
tacaswell
merged commit 45c64e2
into matplotlib:master
Dec 2, 2016
|
sorry, I think I was too optimistic about merging this. |
Kojoley commentedNov 16, 2016
No description provided.