/matplotlib

Check at least one argument is provided for plt.table #7522

Merged
merged 1 commit into from Nov 28, 2016

Conversation

Reviewers

@efiring efiring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
4 participants
@dstansby @efiring @NelleV @QuLogic
@dstansby
Contributor

dstansby commented Nov 27, 2016

Fixes #7519.

  • ValueError seemed to be the most suitable exception to raise, but I might be wrong.
  • Is it worth adding a test for this or not?
@dstansby dstansby Check at least one argument is provided for plt.table

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.0004%) to 61.886%
Details
1e54084
@efiring

efiring approved these changes Nov 27, 2016
View changes

Looks fine to me.

@efiring
Owner

efiring commented Nov 27, 2016

ValueError is appropriate. I do not think a test should be added for this.

efiring changed the title from Check at least one argument is provided for plt.table to [MRG+1] Check at least one argument is provided for plt.table Nov 27, 2016

@NelleV NelleV merged commit e0fcf3f into matplotlib:master Nov 28, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0004%) to 61.886%
Details
@NelleV
Contributor

NelleV commented Nov 28, 2016

Thanks @dstansby for the patch!
@QuLogic
Member

QuLogic commented Nov 28, 2016

Backport?
@efiring
Owner

efiring commented Nov 28, 2016

Sure, go ahead.

@QuLogic QuLogic added a commit that referenced this pull request Dec 7, 2016

@NelleV @QuLogic NelleV + QuLogic Merge pull request #7522 from dstansby/table-argcheck 
Check at least one argument is provided for plt.table
 aef8acd

QuLogic added this to the 2.0 (style change major release) milestone Dec 7, 2016

QuLogic changed the title from [MRG+1] Check at least one argument is provided for plt.table to Check at least one argument is provided for plt.table Dec 7, 2016

@QuLogic
Member

QuLogic commented Dec 7, 2016

Backported to v2.x as aef8acd.

dstansby deleted the dstansby:table-argcheck branch Dec 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment