double tolerance for test_png.py/pngsuite on Windows #7531

Merged
merged 1 commit into from Dec 1, 2016

Conversation

Projects
None yet
4 participants
Owner

efiring commented Nov 29, 2016

This is whacking another random Windows mole in an attempt to get past Appveyor.

@efiring efiring double tolerance for test_png.py/pngsuite on Windows
1b3c7d4
Contributor

NelleV commented Nov 30, 2016

I'm closing and reopening. One of the appveyor tests did not seem to run properly.

NelleV closed this Nov 30, 2016

NelleV reopened this Nov 30, 2016

Contributor

NelleV commented Nov 30, 2016

If I am not mistaken, this tackles #6620 and #6604

Owner

efiring commented Nov 30, 2016

No connection to #6620, which is about segfaults on 32-bit systems, not minuscule image failures.
I don't think it is connected to #6604 either, because that is also about 32-bit system-specific image failures--fairly large ones.

So on Windows there seem to be intermittent non-deterministic behavior episodes causing failures sometimes, but not always or on all of the runs. That's what the present trivial PR addresses--one such example. I expect many more will crop up over time.

In addition, it seems there are some real problems with 32-bit systems behaving differently than 64-bit systems, which should not happen. That's much harder to deal with, and I suspect impossible for us to track down. The problem is likely buried deep in some library, maybe with a helping hand from a CPU bug.

NelleV changed the title from double tolerance for test_png.py/pngsuite on Windows to [MRG+1] double tolerance for test_png.py/pngsuite on Windows Dec 1, 2016

@tacaswell tacaswell merged commit 3fad2d5 into matplotlib:master Dec 1, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 61.886%
Details

QuLogic changed the title from [MRG+1] double tolerance for test_png.py/pngsuite on Windows to double tolerance for test_png.py/pngsuite on Windows Dec 1, 2016

QuLogic added this to the 2.1 (next point release) milestone Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment