Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Deprecate unused functions in cbook. #7568
Conversation
| @@ -2569,6 +2607,7 @@ def normalize_kwargs(kw, alias_mapping=None, required=(), forbidden=(), | ||
| return ret | ||
| +@deprecated('2.0') |
tacaswell
added this to the
2.1 (next point release)
milestone
Dec 5, 2016
|
Given that we just did an rc without these, I think they should target 2.1 instead of 2.0. |
|
I actually think that everything currently tagged 2.0.1 that isn't a major bug should target 2.1 |
|
@NelleV Agree, except scratch the work 'major'. Any bugfix should target the next bugfix release. |
|
Sounds fair. |
NelleV
changed the title from
Deprecate unused functions in cbook. to [MRG+1] Deprecate unused functions in cbook.
Dec 19, 2016
|
This is long overdue… Thanks for tackling this @anntzer ! |
| @@ -931,6 +952,7 @@ def xlat(self, text): | ||
| return self._make_regex().sub(self, text) | ||
| +@deprecated('2.1') | ||
| def soundex(name, len=4): |
tacaswell
Dec 20, 2016
Owner
Dates back to e34a333 (Sept 2004!). Presumably John used this for something....
QuLogic
changed the title from
[MRG+1] Deprecate unused functions in cbook. to Deprecate unused functions in cbook.
Dec 19, 2016
QuLogic
merged commit a15d5c8
into matplotlib:master
Dec 19, 2016
anntzer
deleted the
anntzer:deprecate-unused-cbook branch
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anntzer commentedDec 5, 2016
I think most of the deprecations I propose should be pretty uncontroversial, but feel free to argue otherwise. Let's see whether we can work on reducing the old API...