Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Clean up stock sample data. #7645
Conversation
QuLogic
added this to the
2.1 (next point release)
milestone
Dec 19, 2016
NelleV
changed the title from
Clean up stock sample data. to [MRG+1] Clean up stock sample data.
Dec 31, 2016
codecov-io
commented
Jan 4, 2017
Current coverage is 62.16% (diff: 100%)@@ master #7645 diff @@
==========================================
Files 174 174
Lines 56021 56664 +643
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34773 35225 +452
- Misses 21248 21439 +191
Partials 0 0
|
|
Thanks for the clean up! |
NelleV
merged commit b1f4820
into matplotlib:master
Jan 13, 2017
5 checks passed
codecov/patch
Coverage not affected when comparing ab98852...9ba1fd5
Details
codecov/project
62.16% (+0.09%) compared to ab98852
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
coverage/coveralls
Coverage increased (+0.09%) to 62.165%
Details
QuLogic
deleted the
QuLogic:sample-data-cleanup branch
Jan 13, 2017
QuLogic
changed the title from
[MRG+1] Clean up stock sample data. to Clean up stock sample data.
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
QuLogic commentedDec 19, 2016
This is a followup to #7559 with the cleanup of the stock sample data that was taken out of there.
AAPL and INTC are no longer required without stock_demo.py, plus there are 3 copies of AAPL data. Convert
datetime.datetonp.datetime64to increase portability of the files.While using
np.datetime64in the NumPy files is more portable across Python versions, Matplotlib still really only supportsdatetimeobjects, so I've had to convert back after loading. This is a bit suboptimal (but not really worse than the existing setup), so now that we depend on NumPy 1.7 which has had a few improvements, it may be time to look into importing thenp.datetime64converter.