Clean up stock sample data. #7645

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
4 participants
Member

QuLogic commented Dec 19, 2016

This is a followup to #7559 with the cleanup of the stock sample data that was taken out of there.

AAPL and INTC are no longer required without stock_demo.py, plus there are 3 copies of AAPL data. Convert datetime.date to np.datetime64 to increase portability of the files.

While using np.datetime64 in the NumPy files is more portable across Python versions, Matplotlib still really only supports datetime objects, so I've had to convert back after loading. This is a bit suboptimal (but not really worse than the existing setup), so now that we depend on NumPy 1.7 which has had a few improvements, it may be time to look into importing the np.datetime64 converter.

QuLogic added this to the 2.1 (next point release) milestone Dec 19, 2016

@QuLogic QuLogic Clean up stock sample data.
AAPL and INTC are no longer required without stock_demo.py, plus there
are 3 copies of AAPL data. Convert datetime.date to np.datetime64 to
increase portability of the files.
9ba1fd5
@Kojoley

Disclaimer: I've checked examples only on Py3.5

NelleV changed the title from Clean up stock sample data. to [MRG+1] Clean up stock sample data. Dec 31, 2016

Current coverage is 62.16% (diff: 100%)

Merging #7645 into master will increase coverage by 0.09%

@@             master      #7645   diff @@
==========================================
  Files           174        174          
  Lines         56021      56664   +643   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34773      35225   +452   
- Misses        21248      21439   +191   
  Partials          0          0          

Powered by Codecov. Last update ab98852...9ba1fd5

Contributor

NelleV commented Jan 13, 2017

Thanks for the clean up!
This looks good.

@NelleV NelleV merged commit b1f4820 into matplotlib:master Jan 13, 2017

5 checks passed

codecov/patch Coverage not affected when comparing ab98852...9ba1fd5
Details
codecov/project 62.16% (+0.09%) compared to ab98852
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 62.165%
Details

QuLogic deleted the QuLogic:sample-data-cleanup branch Jan 13, 2017

QuLogic changed the title from [MRG+1] Clean up stock sample data. to Clean up stock sample data. Jan 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment