Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Save SVG test directly to file instead of its name. #7668
+2
−2
Conversation
QuLogic
added backend/svg Testing
labels
Dec 22, 2016
QuLogic
added this to the
2.1 (next point release)
milestone
Dec 22, 2016
QuLogic
added the
OS/Microsoft
label
Dec 22, 2016
|
Not sure why this didn't fail in #6428 originally, but the timing seems close enough. |
QuLogic
requested review from jkseppan and Kojoley
Dec 22, 2016
codecov-io
commented
Dec 23, 2016
Current coverage is 62.07% (diff: 100%)@@ master #7668 diff @@
==========================================
Files 109 174 +65
Lines 46633 56007 +9374
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 31049 34765 +3716
- Misses 15584 21242 +5658
Partials 0 0
|
|
Yay, it passed! |
tacaswell
merged commit 8b80068
into matplotlib:master
Dec 23, 2016
4 of 5 checks passed
coverage/coveralls
Coverage decreased (-4.5%) to 62.073%
Details
codecov/patch
Coverage not affected when comparing 7131876...2679ddd
Details
codecov/project
Absolute coverage decreased by -4.50% but relative coverage increased by +33.41% compared to 7131876
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
QuLogic
deleted the
QuLogic:fix-svg-test-windows branch
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
QuLogic commentedDec 22, 2016
Windows doesn't like opening files twice, so this needs to save to the file name outside the context (after it's been closed), or simply write to the file object directly. There doesn't seem to be any pressing need to use the file name, so just use the file object.
Hopefully, this will fix AppVeyor.