Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Serialize comparison of multiple baseline images. #7674
+16
−6
Conversation
QuLogic
added the
Testing
label
Dec 23, 2016
QuLogic
added this to the
2.1 (next point release)
milestone
Dec 23, 2016
|
And it died on something else; not sure if that's proof it's working or just bad luck. |
That looks like bad-luck, restarted. |
|
Yeah, this test fails for all builds from time to time. |
codecov-io
commented
Dec 23, 2016
•
Current coverage is 62.06% (diff: 100%)@@ master #7674 diff @@
==========================================
Files 109 174 +65
Lines 46633 56007 +9374
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 31049 34763 +3714
- Misses 15584 21244 +5660
Partials 0 0
|
tacaswell
merged commit c21d189
into matplotlib:master
Dec 23, 2016
4 of 5 checks passed
coverage/coveralls
Coverage decreased (-4.5%) to 62.069%
Details
codecov/patch
Coverage not affected when comparing c4caab8...dfe0f63
Details
codecov/project
Absolute coverage decreased by -4.51% but relative coverage increased by +33.41% compared to c4caab8
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
QuLogic
deleted the
QuLogic:serialize-baseline-compare branch
Dec 24, 2016
Kojoley
referenced
this pull request
Dec 31, 2016
Closed
Baseline image reuse breaks parallel testing #7673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
QuLogic commentedDec 23, 2016
This prevents the results from stomping on one another, though it doesn't fix the case of multiple tests using the same baseline image.
See #7673 for an explanation. Since there are so many tests with multiple copies of the same baseline (it's not a huge amount, but enough, apparently), this seems like a reasonable workaround.