Set slider to min/max constraint when value exceeds constraint. #770

Merged
merged 1 commit into from May 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

tonysyu commented Mar 16, 2012

Currently, when a slider's limits are constrained by another slider (using slidermin/slidermax), the slider will simply return unchanged when you move the slider beyond the limits.

Instead, the slider should update to the min/max value when closedmin/closedmax attributes are True. This would match the behavior of the valmin/valmax limits.

@tonysyu tonysyu Set slider to min/max constraint when value exceeds constraint.
Currently, when a slider's limits are constrained by another slider (using `slidermin/slidermax`), the slider will simply return unchanged when you move the slider beyond the limits.

Instead, the slider should update to the min/max value when `closedmin/closedmax` attributes are True. This would match the behavior of the `valmin/valmax` limits.
b61507b
Member

WeatherGod commented May 14, 2012

This change looks ok to me. Sorry for the delay. Tony, I take it that you haven't encountered any issues with this change?

Contributor

tonysyu commented May 14, 2012

I've used it a bit on a simple interactive plot and it worked perfectly for my purposes. And I can't see why there would be any corner cases.

Thanks for reviewing.

Member

WeatherGod commented May 14, 2012

Agreed. Pulling...

@WeatherGod WeatherGod added a commit that referenced this pull request May 14, 2012

@WeatherGod WeatherGod Merge pull request #770 from tonysyu/slider-constraint-fix
Set slider to min/max constraint when value exceeds constraint.
91310f8

@WeatherGod WeatherGod merged commit 91310f8 into matplotlib:master May 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment