/matplotlib

For make raw_input compatible with python3 #7729

Merged
merged 2 commits into from Jan 11, 2017
+5 −1

Conversation

Reviewers

@tacaswell tacaswell

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
  v2.0.1
5 participants
@rishikksh20 @tacaswell @codecov-io @QuLogic @NelleV
@rishikksh20
Contributor

rishikksh20 commented Jan 2, 2017

Fix issue #7388
@tacaswell
Owner

tacaswell commented Jan 3, 2017

Can you either un-densify this (we enforce pep8/pycodestlye as part of our test suite) or use from six.moves import input?

tacaswell added this to the 2.0.1 (next bug fix release) milestone Jan 3, 2017

tacaswell added the Documentation label Jan 3, 2017

@tacaswell

tacaswell requested changes Jan 3, 2017
View changes

Either add new lines or use from six.moves import input

@rishikksh20
Contributor

rishikksh20 commented Jan 3, 2017 • edited

Ok @tacaswell first let me add new lines if its work for pep8 issue then done. Otherwise I will use
from six.moves import input and then squash all my commits .

rishikksh20 added some commits Jan 1, 2017

@rishikksh20 @rishikksh20 rishikksh20 For make raw_input compatible with python3 
Fix issue #7388
 5a50fd5
@rishikksh20 @rishikksh20 rishikksh20 To remove pep8 warnings 
This commit remove the pep8 warning from this file

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing 20315e1...fdf4d61
Details
codecov/project — 62.12% (+0.00%) compared to 20315e1
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 62.121%
Details
fdf4d61
@rishikksh20
Contributor

rishikksh20 commented Jan 4, 2017

@tacaswell its done please review it and let me know if any other modification required.
@codecov-io

codecov-io commented Jan 4, 2017

Current coverage is 62.12% (diff: 100%)

Merging #7729 into master will not change coverage

@@             master      #7729   diff @@
==========================================
  Files           174        174          
  Lines         56028      56028          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          34805      34805          
  Misses        21223      21223          
  Partials          0          0

Powered by Codecov. Last update 20315e1...fdf4d61
@tacaswell
Owner

tacaswell commented Jan 4, 2017

Please do not backport this until after 2.0 final is out.

@NelleV NelleV merged commit 27bc177 into matplotlib:master Jan 11, 2017
5 checks passed

5 checks passed

codecov/patch Coverage not affected when comparing 20315e1...fdf4d61
Details
codecov/project 62.12% (+0.00%) compared to 20315e1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 62.121%
Details

naoyak referenced this pull request Jan 22, 2017

Open

Example examples/misc/multiprocess.py may not be python3 compatible? #7388

@QuLogic
Member

QuLogic commented Jan 30, 2017 • edited

Backported to v2.0.0-doc as 68d2327.

@QuLogic QuLogic added a commit that referenced this pull request Jan 30, 2017

@NelleV @QuLogic NelleV + QuLogic Merge pull request #7729 from rishikksh20/master 
For make raw_input compatible with python3
 68d2327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment