Update qhull to 2015.2 #7747

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
None yet
4 participants
Member

ianthomas23 commented Jan 5, 2017

This PR updates the qhull source code that we ship with matplotlib to be the latest version, 2015.2. There is no change in functionality.

I was going to change it to use the new reentrant version of qhull which is somewhat more thread safe. However, in trying this I unearthed a bug in debian-based distributions which ship the reentrant header files but not the shared library (libqhull_r.so). I have reported this to debian many weeks ago (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841168), but there hasn't even been an acknowledgement of the bug yet never mind a fix. Shipping mpl using the reentrant version whilst this bug still exists would result in lots of failed installs, so I have stuck to the original non-reentrant version and will write another PR when debian fix the bug.

Assuming this passes the tests and everyone is happy with it, it will close issue #6791.

Owner

tacaswell commented Jan 5, 2017

Restarted the 2 failed tests (look transient to me).

I see no reason not to do this.

tacaswell added this to the 2.1 (next point release) milestone Jan 5, 2017

Owner

tacaswell commented Jan 5, 2017

@ianthomas23 Can you add a note to whats_new or api_changes (which ever you think is better) noting we bumped the vendored version.

codecov-io commented Jan 5, 2017 edited

Current coverage is 62.12% (diff: 100%)

Merging #7747 into master will not change coverage

@@             master      #7747   diff @@
==========================================
  Files           174        174          
  Lines         56028      56028          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          34805      34805          
  Misses        21223      21223          
  Partials          0          0          

Powered by Codecov. Last update 1fa4dd7...9a658c0

@ianthomas23 ianthomas23 Update qhull to 2015.2
9a658c0
Member

ianthomas23 commented Jan 6, 2017

@tacaswell I've added an entry to api_changes, and squashed that commit.

@NelleV

NelleV approved these changes Jan 13, 2017

@NelleV NelleV merged commit 3290d19 into matplotlib:master Jan 13, 2017

5 checks passed

codecov/patch Coverage not affected when comparing 1fa4dd7...9a658c0
Details
codecov/project 62.12% (+0.00%) compared to 1fa4dd7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 62.121%
Details
Contributor

NelleV commented Jan 13, 2017

Thanks @ianthomas23 !

QuLogic referenced this pull request May 15, 2017

Closed

Updating Qhull? #6791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment