Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Use backports.functools_lru_cache instead of functools32 #7871
Conversation
QuLogic
requested a review
from mdboom
Jan 19, 2017
anntzer
referenced
this pull request
Jan 20, 2017
Open
Differing dependencies of matplotlib 2.0 with Python 3 and Python 2 #7893
tacaswell
added this to the
2.1 (next point release)
milestone
Jan 20, 2017
|
I am mixed on this. A bit worried that changing the deps is going to just cause havoc for down-stream packagers as this is a new for 2.0 dependency, but sympathetic to using a more widely used / better maintained backport. |
|
I guess the havoc would be limited, since most distros have pylint packaged, they will have backports.functools_lru_cache already :) |
|
Apparently pylint only started depending on backports.functools_lru_cache recently (PyCQA/pylint@02f6823). For example, a quick search on pkgs.org suggests that none of CentOS, Debian Jessie, Mageia and Ubuntu (in their latest versions) provide that package right now. |
|
Not a linux distributor, but I bundle packages nonetheless and https://pypi.python.org/pypi/backports.functools_lru_cache seems to be a more mature package on a quick glance. |
|
I am fine either way. @tacaswell I think you should be the one making the decision on this change, as you are the maintainer |
|
I am |
|
API changes file added :) |
|
Hrm, the test failure looks irrelevant. |
NelleV
merged commit 4cfbb2f
into matplotlib:master
Feb 16, 2017
4 of 5 checks passed
|
Thanks @felixonmars ! |
felixonmars commentedJan 19, 2017
It's better maintained and more widely used (by pylint, jaraco, etc).