Fix pyplot.axis(ax) when ax is in other figure.

[pavoljuhas]

Avoid crash when ax belongs to some other than the current figure.
Make the ax owner the current figure instead.

This resolves crash in axes call in the following stanza

from matplotlib.pyplot import *
f1, a1 = subplots()
f2, a2 = subplots()
axes(a1)
assert gca() is a1
assert gcf() is f1

[dopplershift]

Is there any chance you could add a test in test_axes.py that replicates the crash? It could be as simple as:

def test_set_axes_different_figure():
    f1, a1 = plt.subplots()
    f2, a2 = plt.subplots()
    plt.axes(a1)
    assert plt.gca() is a1
    assert plt.gcf() is f1

This way we don't accidentally break it in the future.

[pavoljuhas]

Sure, I'll get to it later today or tomorrow.

[NelleV]

LGTM
Thanks!

[dstansby]

Thanks for the fix! 🤦‍♂️ I should check the tests before I approve something next time.

[dstansby]

Just a couple of test fixes needed.

[dstansby]

Could the new lines go in a new function?

[pavoljuhas]

Indeed test_as_mpl_axes_api seems to be for customizations with the _as_mpl_axes function. I will add the new function.

[dstansby]

These two lines need to be plt.subplots()

[QuLogic]

This comment is one line below where it should be.

[dstansby]

Woops, thanks for spotting that

[pavoljuhas]

Fixed - thanks for catching that.