/matplotlib

Undeprecate is_scalar_or_string. #8055

Merged
merged 1 commit into from Feb 11, 2017
+0 −1

Conversation

Reviewers

@QuLogic QuLogic

@dstansby dstansby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
4 participants
@anntzer @QuLogic @dstansby @NelleV
@anntzer
Contributor

anntzer commented Feb 9, 2017

See #8054.
@anntzer anntzer Undeprecate is_scalar_or_string.

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing e6e8468...86c851a
Details
codecov/project/library — 62.28% remains the same compared to e6e8468
Details
codecov/project/tests — 97.97% (target 97.7%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
86c851a
@anntzer
Contributor

anntzer commented Feb 9, 2017

attn @QuLogic

QuLogic added this to the 2.1 (next point release) milestone Feb 10, 2017

@QuLogic
Member

QuLogic commented Feb 10, 2017

Do you still plan to remove it in the end?
@anntzer
Contributor

anntzer commented Feb 10, 2017

Hopefully yes, but I need to check the few call sites more carefully.

NelleV closed this Feb 10, 2017

NelleV reopened this Feb 10, 2017

@dstansby dstansby merged commit 96c75be into matplotlib:master Feb 11, 2017
5 checks passed

5 checks passed

codecov/patch Coverage not affected when comparing e6e8468...86c851a
Details
codecov/project/library 62.28% remains the same compared to e6e8468
Details
codecov/project/tests 97.97% (target 97.7%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

anntzer deleted the anntzer:undeprecate-is_scalar_or_string branch Feb 11, 2017

anntzer referenced this pull request Mar 15, 2017

Closed

is_scalar_or_string deprecated too early #8054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment