/matplotlib

Clean up and move accented text example #8065

Merged
merged 5 commits into from Feb 23, 2017
+38 −38

Conversation

Reviewers

@tacaswell tacaswell

@QuLogic QuLogic

@phobson phobson

@NelleV NelleV

@anntzer anntzer

Assignees
No one assigned
Labels
Documentation
Projects

Done in Reviewing pull requests.

Milestone
  2.1 (next point r...
6 participants
@dstansby @NelleV @tacaswell @QuLogic @phobson @anntzer
@dstansby
Contributor

dstansby commented Feb 12, 2017

I thought I'd kick off the docathon by moving and cleaning the first example in pylab_examples.
@dstansby dstansby Clean up and move accented text example

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing 3d99e43...2665eab
Details
codecov/project/library — 62.28% remains the same compared to 3d99e43
Details
codecov/project/tests — 97.97% (target 97.7%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
2665eab

dstansby added the Documentation label Feb 12, 2017

examples/text_labels_and_annotations/accented_text.py
+Matplotlib supports accented characters via TeX mathtext.
@QuLogic

QuLogic Feb 12, 2017

Member

Also supported through regular Unicode characters, though that's not shown here.

@tacaswell

tacaswell Feb 13, 2017

Owner

I am 👍 on making this file utf-8 encoded and adding some accented characters.

@anntzer

anntzer Feb 16, 2017

Contributor

Perhaps merge it with unicode_demo.py then? See also #8083.

NelleV added this to the 2.1 (next point release) milestone Feb 16, 2017

@NelleV

NelleV approved these changes Feb 16, 2017
View changes

LGTM 👍

NelleV changed the title from Clean up and move accented text example to [MRG+1] Clean up and move accented text example Feb 16, 2017

anntzer referenced this pull request Feb 16, 2017

Closed

Improvements to Gallery - Removing accented_text.html & unicode_demo.html #8083

@anntzer

anntzer requested changes Feb 16, 2017
View changes

(marking a change request so that the option of merging with unicode_demo.py is more visible -- especially given the overlap with #8083. @dstansby feel free dismiss this review if you don't plan to do so, but then you get to take care of #8083 :-))

dstansby added some commits Feb 16, 2017

@dstansby dstansby Merge unicode_demo into accented_text 2a6bd58
@dstansby dstansby Remove unicode_demo

Some checks were not successful

1 failing and 4 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
codecov/patch — Coverage not affected when comparing 3d99e43...b430281
Details
codecov/project/library — 62.34% (+0.06%) compared to 3d99e43
Details
codecov/project/tests — 97.98% (target 97.7%)
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
b430281
@dstansby
Contributor

dstansby commented Feb 16, 2017

👍 done.

nb. I am just ignoring backend_driver for now, since one of my other PRs will get rid of needing to specify tests one by one and manually keeping track of them.
examples/text_labels_and_annotations/accented_text.py
+ax.set_title(r'$\ddot{o}\acute{e}\grave{e}\hat{O}'
+ r'\breve{i}\bar{A}\tilde{n}\vec{q}$', fontsize=20)
+
+# Shorthand is also supported and curly's are optional
@anntzer

anntzer Feb 16, 2017

Contributor

"curlies" perhaps?

@anntzer

anntzer Feb 20, 2017

Contributor

attn @dstansby

@phobson

phobson Feb 21, 2017

Member

curly braces?

examples/text_labels_and_annotations/accented_text.py
+# Unicode demo
+fig, ax = plt.subplots()
+ax.set_title('Développés et fabriqués')
+ax.set_xlabel("réactivité nous permettent d'être sélectionnés et adoptés")
@anntzer

anntzer Feb 16, 2017

Contributor

Actually both French sentences are meaningless. If we want to keep some foreign languages, I can propose

GISCARD CHAHUTÉ À L'ASSEMBLÉE
LE COUP DE DÉ DE DE GAULLE

(famous examples where keeping accents on caps is needed for the sentence to make any sense) :-)

@tacaswell

tacaswell Feb 17, 2017

Owner

Buffalo buffalo buffalo buffalo ?

@anntzer

anntzer Feb 17, 2017

Contributor

I guess English would benefit from diacritics too...

@dstansby

dstansby Feb 17, 2017

Contributor

Thanks for the suggestions!

@dstansby dstansby Update accented text sentences@

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing 3d99e43...1122dc5
Details
codecov/project/library — 62.28% (+<.01%) compared to 3d99e43
Details
codecov/project/tests — 97.97% (target 97.7%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
1122dc5

dstansby added to Needs review in Reviewing pull requests. Feb 18, 2017

@dstansby dstansby Curlies --> curly braces

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing 3d99e43...a14b453
Details
codecov/project/library — 62.82% (+0.54%) compared to 3d99e43
Details
codecov/project/tests — 98.84% (target 97.7%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
a14b453

@QuLogic QuLogic merged commit a34c859 into matplotlib:master Feb 23, 2017
5 checks passed

5 checks passed

codecov/patch Coverage not affected when comparing 3d99e43...a14b453
Details
codecov/project/library 62.82% (+0.54%) compared to 3d99e43
Details
codecov/project/tests 98.84% (target 97.7%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

QuLogic changed the title from [MRG+1] Clean up and move accented text example to Clean up and move accented text example Feb 23, 2017

QuLogic moved from Needs review to Done in Reviewing pull requests. Feb 23, 2017

anntzer referenced this pull request Feb 26, 2017

Open

Suggested improvements to the gallery #7956

12 of 16 tasks complete

dstansby deleted the dstansby:doc-accented-text branch Apr 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment