/matplotlib

Remove example of matrix of size (12, 12) and (64, 64) #8094

Merged
merged 2 commits into from Feb 18, 2017

Conversation

Reviewers

@anntzer anntzer

@dstansby dstansby

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
  v2.0.1
5 participants
@patniharshit @tacaswell @anntzer @dstansby @afvincent
@patniharshit
Contributor

patniharshit commented Feb 17, 2017 • edited

refs #7956 Only keep middle plots
Remove first and third example and keep second one.
@patniharshit patniharshit Remove example of matrix of size (12, 12) and (64, 64)

Some checks were not successful

3 failing and 2 successful checks
codecov/project/library — 62.22% (-0.06%) compared to 5e825bd
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
codecov/patch — Coverage not affected when comparing 5e825bd...53c5560
Details
codecov/project/tests — 97.94% (target 97.7%)
Details
53c5560
examples/pylab_examples/matshow.py
@@ -10,17 +10,7 @@ def samplemat(dims):
aa[i, i] = i
@anntzer

anntzer Feb 17, 2017

Contributor

Could be rewritten as np.fill_diagonal(aa, range(min(dims))).

@dstansby

dstansby Feb 17, 2017

Contributor

I think the current version is much more readable, which is important for an example.

@anntzer

anntzer Feb 17, 2017

Contributor

I'm fine either way.

examples/pylab_examples/matshow.py
-# Display a random matrix with a specified figure number and a grayscale
-# colormap
-plt.matshow(np.random.rand(64, 64), fignum=100, cmap=plt.cm.gray)
+# Display matrix
@anntzer

anntzer Feb 18, 2017

Contributor

two spaces, and trailing whitespace.

@patniharshit

patniharshit Feb 18, 2017

Contributor

Should I remove spaces ?

@anntzer

anntzer Feb 18, 2017

Contributor

one before "matrix" and whatever is after.

@patniharshit patniharshit remove spaces in comment

Some checks were not successful

2 failing and 3 successful checks
codecov/project/library — 62.22% (-0.06%) compared to 5e825bd
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
codecov/patch — Coverage not affected when comparing 5e825bd...f944078
Details
codecov/project/tests — 97.94% (target 97.7%)
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
f944078
@tacaswell
Owner

tacaswell commented Feb 18, 2017

@anntzer I find your review confusing, you asked for changes with the comment 'LGTM' ;)
@anntzer
Contributor

anntzer commented Feb 18, 2017

I noticed the spaces issue afterwards and forgot to edit the main message :-)

anntzer changed the title from Remove example of matrix of size (12, 12) and (64, 64) to [MRG+1] Remove example of matrix of size (12, 12) and (64, 64) Feb 18, 2017

@dstansby

dstansby approved these changes Feb 18, 2017
View changes

Thanks!

dstansby changed the title from [MRG+1] Remove example of matrix of size (12, 12) and (64, 64) to Remove example of matrix of size (12, 12) and (64, 64) Feb 18, 2017

@dstansby dstansby merged commit 3b9a916 into matplotlib:master Feb 18, 2017
3 of 5 checks passed

3 of 5 checks passed

codecov/project/library 62.22% (-0.06%) compared to 5e825bd
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
codecov/patch Coverage not affected when comparing 5e825bd...f944078
Details
codecov/project/tests 97.94% (target 97.7%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

dstansby added this to the 2.0.1 (next bug fix release) milestone Feb 18, 2017

anntzer referenced this pull request Feb 18, 2017

Open

Suggested improvements to the gallery #7956

12 of 16 tasks complete

@dstansby dstansby added a commit that referenced this pull request Feb 18, 2017

@dstansby dstansby Merge pull request #8094 from patniharshit/keepmiddle 
Remove example of matrix of size (12, 12) and (64, 64)
 35996ce
@dstansby
Contributor

dstansby commented Feb 18, 2017

Backported to 2.0.x via 35996ce

patniharshit deleted the unknown repository branch Feb 19, 2017

afvincent added the Documentation label Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment