Improve error message for image_comparison decorator. #8096

Merged
merged 1 commit into from Feb 18, 2017

Conversation

Projects
None yet
3 participants
Contributor

anntzer commented Feb 18, 2017

The name of the test is already reported by pytest; the mismatching
number of images is more useful.

If a non-callable is passed to the decorator the test will fail
normally and be reported as such by pytest; no need to check for it.

@anntzer anntzer Improve error message for image_comparison decorator.
The name of the test is already reported by pytest; the mismatching
number of images is more useful.

If a non-callable is passed to the decorator the test will fail
normally and be reported as such by pytest; no need to check for it.
224305c
@dstansby

👍 Looks good to me (and it works too!)

dstansby changed the title from Improve error message for image_comparison decorator. to [MRG+1] Improve error message for image_comparison decorator. Feb 18, 2017

dstansby added the Testing label Feb 18, 2017

dstansby added this to the 2.1 (next point release) milestone Feb 18, 2017

@NelleV

NelleV approved these changes Feb 18, 2017

@NelleV NelleV merged commit 5f98750 into matplotlib:master Feb 18, 2017

4 of 5 checks passed

codecov/project/library 62.28% (-0.01%) compared to 5e825bd
Details
codecov/patch Coverage not affected when comparing 5e825bd...224305c
Details
codecov/project/tests 97.97% (target 97.7%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

QuLogic changed the title from [MRG+1] Improve error message for image_comparison decorator. to Improve error message for image_comparison decorator. Feb 19, 2017

anntzer deleted the anntzer:improve-imagecomparisondecorator-error-message branch Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment