Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Drop None from Container.get_children(). #8119
+3
−4
Conversation
|
So now it'll return an empty list? Am I reading that right? Containers are hardly tested. Could we add some to cover this case? |
tacaswell
added this to the
2.1 (next point release)
milestone
Feb 21, 2017
|
@phobson Yes, yes, and go ahead :) |
|
Does this need an api change note? |
|
Technically the API doesn't change (you can't rely on indexing the results of |
NelleV
merged commit db9e631
into matplotlib:master
Feb 22, 2017
5 checks passed
codecov/patch
100% of diff hit (target 80%)
Details
codecov/project/library
62.36% (+0.06%) compared to 2bce760
Details
codecov/project/tests
98.87% (target 97.9%)
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
anntzer
deleted the
anntzer:drop-None-container-children branch
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anntzer commentedFeb 21, 2017
Before the patch,
would print
None(corresponding to the "not drawn" line connecting thedata points), two
Line2Dand oneLineCollection.This patch drops the
Noneout, as it is arguably not a child of theContainer. (It is still possible to access the individual members of
the Container by unpacking it as a tuple.)
Also reformat an overly indented piece of code in the vicinity.