/matplotlib

Remove support for -dbackend argv. #8148

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Reviewers

@QuLogic QuLogic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
3 participants
@anntzer @tacaswell @QuLogic
@anntzer
Contributor

anntzer commented Feb 25, 2017

Support for setting the backend with -dbackend was deprecated in 1.5 (#3710).

QuLogic added this to the 2.1 (next point release) milestone Feb 25, 2017

@QuLogic

QuLogic requested changes Feb 25, 2017
View changes

Changed my mind because there are still a few places that you missed:

  • doc/devel/contributing.rst
  • doc/faq/environment_variables_faq.rst
  • doc/users/prev_whats_new/whats_new_0.98.4.rst (iffy)
@anntzer
Contributor

anntzer commented Feb 25, 2017

Thanks for the quick review, fixed the points you mentioned, with the exception of the 0.98.4 whatsnew (I'd rather not touch old whatsnews).
@tacaswell
Owner

tacaswell commented Feb 26, 2017

Can you start a 'removed_code' file in API changes? Other than that 👍
@anntzer anntzer Remove support for -dbackend argv. 
Support for setting the backend with `-dbackend` was deprecated in 1.5.

All checks have passed

5 successful checks
codecov/patch — 100% of diff hit (target 80%)
Details
codecov/project/library — 57.96% (+<.01%) compared to 4a2c850
Details
codecov/project/tests — 98.57% (target 97.9%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
781872e
@anntzer
Contributor

anntzer commented Feb 26, 2017

Done.

@tacaswell tacaswell merged commit a6c32f8 into matplotlib:master Feb 26, 2017
5 checks passed

5 checks passed

codecov/patch 100% of diff hit (target 80%)
Details
codecov/project/library 57.96% (+<.01%) compared to 4a2c850
Details
codecov/project/tests 98.57% (target 97.9%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tacaswell
Owner

tacaswell commented Feb 26, 2017

Thanks!

anntzer deleted the anntzer:remove--dbackend-flag branch Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment