Addresses #8177, Readme badges #8178

Merged
merged 4 commits into from Mar 2, 2017

Conversation

Projects
None yet
4 participants
Contributor

epintozzi commented Mar 2, 2017

Added badges for: Travis, Appveyor, Codecov, pypi, gitter, and depsy

epintozzi added some commits Mar 2, 2017

@epintozzi epintozzi add badges 7c22928
@epintozzi epintozzi add badges 6b501ea
@epintozzi epintozzi gitter badge e569bab
@epintozzi epintozzi use svg for travis badge
ac6cbf8
Contributor

anntzer commented Mar 2, 2017 edited

I would suggest a plain text gitter link next to the mailing-list section.

You can also update the pypi link so that it points directly to pypi rather than via a redirection.

PS for whoever is reviewing this: you can check how it looks like at https://github.com/epintozzi/matplotlib/tree/readme_badges.

tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 2, 2017

Owner

tacaswell commented Mar 2, 2017

Can we be vain and not include codecov? 😈

Agree on including text link to gitter with the mailing lists

the 'view' button in the review page will also show you the rendering.

@tacaswell

Minor preference for a text link to gitter, but fine with this going in as-is.

Please backport to 2.0.0-doc

QuLogic referenced this pull request Mar 2, 2017

Closed

Add badges to readme #8182

Contributor

dstansby commented Mar 2, 2017

I'll consider that a positive review @tacaswell, and merge!

@dstansby dstansby merged commit 1f173dd into matplotlib:master Mar 2, 2017

4 of 5 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
codecov/patch Coverage not affected when comparing c2f675d...ac6cbf8
Details
codecov/project/library 57.91% (+2.71%) compared to c2f675d
Details
codecov/project/tests 98.56% (target 97.9%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

dstansby commented Mar 2, 2017

This looks like your first contribution to Matplotlib @epintozzi, thanks a lot!

dstansby referenced this pull request Mar 2, 2017

Closed

Add badges to README.rst #8177

@dstansby dstansby added a commit that referenced this pull request Mar 2, 2017

@dstansby dstansby Merge pull request #8178 from epintozzi/readme_badges
Addresses #8177, Readme badges
6e52c51
Contributor

dstansby commented Mar 2, 2017

Backported to 2.0.0-doc via. 6e52c51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment