Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
TST: Enable cache directories on AppVeyor. #8179
Conversation
QuLogic
added OS/Microsoft Testing
labels
Mar 2, 2017
QuLogic
added this to the
2.1 (next point release)
milestone
Mar 2, 2017
|
Grr, of course, in order to get the cache to help, we need to have one run actually work... |
|
I'll watch the Appveyor build and restart it until it passes... |
|
If this finally works this time, I'm going to push another commit and hopefully we'll see that the cache is working. |
|
Pushed another commit to hopefully fix caching on Python 2; 50% of AppVeyor builds are on Python 2. This line shows that Python 2 is trying to put the tarball into the cache now. |
| + except OSError: | ||
| + # Don't care if it exists. | ||
| + pass | ||
| + try: | ||
| shutil.copy(tarball_cache_path, tarball_path) | ||
| print('Using cached tarball: {}' | ||
| .format(tarball_cache_path)) |
QuLogic
added some commits
Mar 2, 2017
|
On Travis, Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 2.7 on macOS and Python nightly are all using the cached tarball now. AppVeyor is not, still. I don't know what's up with it. Maybe caching only works once its gone through |
|
When I run this on |
|
The second build shows AppVeyor restoring the cache and Matplotlib using the cached tarball, so I think this needs to be merged to have any effect on AppVeyor. Interestingly, for those builds, I commented out the test run and it turns out that installing dependencies and building Matplotlib (note, this occurs twice on AppVeyor) take up about 50% of the test wall time, except in the last full-test case. |
|
Something like https://github.com/mozilla/sccache / https://github.com/inorton/cclash / https://github.com/frerich/clcache (basically ccache with msvc support) could be useful? |
|
I was thinking of something like that, but never investigated it. Probably something for another time, when the build queue is not so long... |
|
I think we can merge this PR. It looks good to me. |
NelleV
changed the title from
TST: Enable cache directories on AppVeyor. to [MRG+1] TST: Enable cache directories on AppVeyor.
Mar 8, 2017
dstansby
changed the title from
[MRG+1] TST: Enable cache directories on AppVeyor. to TST: Enable cache directories on AppVeyor.
Mar 8, 2017
dstansby
merged commit 6d4eeff
into matplotlib:master
Mar 8, 2017
5 checks passed
|
Lets see what happens once appveyor gets round to this merge... |
QuLogic commentedMar 2, 2017
No description provided.