/matplotlib

add gitter link in README #8190

Merged
merged 3 commits into from Mar 6, 2017
+1 −3

Conversation

Reviewers

@QuLogic QuLogic

@phobson phobson

@dstansby dstansby

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
  2.1 (next point r...
4 participants
@patniharshit @phobson @dstansby @QuLogic
@patniharshit
Contributor

patniharshit commented Mar 3, 2017

refs #8186
@patniharshit patniharshit add gitter link in README

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing 1f173dd...59b8b3e
Details
codecov/project/library — 57.91% (+<.01%) compared to 1f173dd
Details
codecov/project/tests — 98.56% (target 97.9%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
59b8b3e
README.rst
The first is a good starting point for general questions and discussions.
-
-
+.. image:: https://badges.gitter.im/Join%20Chat.svg
@phobson

phobson Mar 4, 2017

Member

Could you add a sentence that explains that gitter is for coordinating development and asking questions directly related to contributing to matplotlib?

@patniharshit patniharshit add a line to README that explains use of gitter

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing 1f173dd...1286797
Details
codecov/project/library — 57.91% (+<.01%) compared to 1f173dd
Details
codecov/project/tests — 98.56% (target 97.9%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
1286797
@phobson

phobson approved these changes Mar 4, 2017
View changes

phobson changed the title from add gitter link in README to [MRG+1] add gitter link in README Mar 4, 2017

README.rst
The first is a good starting point for general questions and discussions.
+.. image:: https://badges.gitter.im/Join%20Chat.svg
@QuLogic

QuLogic Mar 4, 2017

Member

I don't think we should repeat the image here; just have some text (like the alt text) pointing to the chat room.

README.rst
-
+The gitter is for coordinating development and asking questions directly related to contributing to matplotlib.
@QuLogic

QuLogic Mar 4, 2017 • edited

Member

"The gitter chat room" or just "Gitter", not "The gitter".

@patniharshit patniharshit Replace second instance of gitter badge with a link

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing 1f173dd...37893e7
Details
codecov/project/library — 58.03% (+0.12%) compared to 1f173dd
Details
codecov/project/tests — 98.57% (target 97.9%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
37893e7

dstansby changed the title from [MRG+1] add gitter link in README to [MRG+2] add gitter link in README Mar 6, 2017

@phobson phobson merged commit 0a4c97f into matplotlib:master Mar 6, 2017
5 checks passed

5 checks passed

codecov/patch Coverage not affected when comparing 1f173dd...37893e7
Details
codecov/project/library 58.03% (+0.12%) compared to 1f173dd
Details
codecov/project/tests 98.57% (target 97.9%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

phobson changed the title from [MRG+2] add gitter link in README to add gitter link in README Mar 6, 2017

@phobson
Member

phobson commented Mar 6, 2017

Thanks @patniharshit !

NelleV referenced this pull request Mar 6, 2017

Closed

Put back gitter plain text link on README.rst #8186

QuLogic added this to the 2.0.1 (next bug fix release) milestone Mar 6, 2017

QuLogic added the Needs backport label Mar 6, 2017

patniharshit deleted the patniharshit:addGitterBack branch Mar 19, 2017

@dstansby
Contributor

dstansby commented Mar 25, 2017

Is there any point backporting this since it only appears on github?
@QuLogic
Member

QuLogic commented Mar 25, 2017

I think this corrects something that was already backported, but i don't feel super-strongly about it.

@dstansby dstansby added Documentation and removed Needs backport labels Mar 26, 2017

@dstansby dstansby modified the milestone: 2.1 (next point release), 2.0.1 (next bug fix release) Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment