Mep12 text labels and annotations #8211

Merged
merged 4 commits into from Mar 8, 2017

Conversation

Projects
None yet
5 participants
Contributor

NelleV commented Mar 7, 2017

Here are some more migrations of examples to compatible sphinx-gallery docstring.

refs #7206

NelleV added the Documentation label Mar 7, 2017

NelleV changed the title from Mep12 text labels and annotations to [MRG] Mep12 text labels and annotations Mar 7, 2017

@QuLogic

One typo.

+Controlling style of text and labels using a dictionary
+=======================================================
+
+
@QuLogic

QuLogic Mar 7, 2017

Member

Extra line.

+
+
+This example shows how to share parameters across many text objects and labels
+by creating a dictionnaries of option passed across several functions.
@QuLogic

QuLogic Mar 7, 2017

Member

dictionnaries of option -> dictionary of options

@NelleV NelleV DOC moved text_demo_fontdict to sphinx-gallery compatible docstring
ed1a1a5
Contributor

NelleV commented Mar 7, 2017

Thanks for the review! I fixed the comments.

@QuLogic

Still one typo ;)

+=======================================================
+
+This example shows how to share parameters across many text objects and labels
+by creating a dictionnary of options passed across several functions.
@QuLogic

QuLogic Mar 7, 2017

Member

dictionnary ->dictionary

@NelleV

NelleV Mar 7, 2017

Contributor

fixed again :)

@NelleV NelleV DOC FIX removed a blank line from an example
269b42d
@QuLogic

QuLogic approved these changes Mar 7, 2017

QuLogic changed the title from [MRG] Mep12 text labels and annotations to [MRG+1] Mep12 text labels and annotations Mar 7, 2017

tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 7, 2017

+
+Matplotlib can wrap text automatically, but if it's too long, the text will be
+displayed slightly outside of the boundaries of the axis anyways.
+
@anntzer

anntzer Mar 7, 2017

Contributor

A quick grep suggests that the common style in the codebase is an empty line after the closing quotes, not before.

Also applies below.

@NelleV

NelleV Mar 7, 2017

Contributor

We have common style code for documenting examples? And here I thought we didn't have documentation on examples :p

@NelleV NelleV DOC removed/added blankspace
48e608f
Contributor

NelleV commented Mar 7, 2017

I've added/removed blank lines.

@anntzer

anntzer approved these changes Mar 7, 2017

@dstansby

Will merge if the doc build on travis passes 👍

dstansby self-assigned this Mar 7, 2017

Contributor

NelleV commented Mar 8, 2017

So… The documentation passes. The rest fails because it can't download freetype.

@dstansby dstansby merged commit e88957d into matplotlib:master Mar 8, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

dstansby removed their assignment Apr 10, 2017

@dstansby dstansby added a commit that referenced this pull request May 1, 2017

@dstansby dstansby Merge pull request #8211 from NelleV/MEP12_text_labels_and_annotations
Mep12 text labels and annotations
605e57b
Contributor

dstansby commented May 1, 2017

Backported to 2.0.x via. 605e57b

QuLogic changed the title from [MRG+1] Mep12 text labels and annotations to Mep12 text labels and annotations May 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment