/matplotlib

Mep12 ticks and spines #8212

Merged
merged 4 commits into from Mar 7, 2017

Conversation

Reviewers

@tacaswell tacaswell

@QuLogic QuLogic

@anntzer anntzer

Assignees
No one assigned
Labels
Documentation MEP12
Projects
None yet
Milestone
  v2.0.1
5 participants
@NelleV @tacaswell @anntzer @dstansby @QuLogic
@NelleV
Contributor

NelleV commented Mar 7, 2017

I've merged two examples and wrote documentation for a bunch of others.

refs #7206

NelleV added some commits Mar 7, 2017

@NelleV NelleV DOC spines example are now sphinx-gallery compliant 865996c
@NelleV NelleV DOC all tick labels examples are now sphinx-gallery compatible

All checks have passed

5 successful checks
codecov/patch — Coverage not affected when comparing 5faff6e...0cb9d5e
Details
codecov/project/library — 57.96% (+0.05%) compared to 5faff6e
Details
codecov/project/tests — 98.56% (target 97.9%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
0cb9d5e

NelleV changed the title from Mep12 ticks and spines to [MRG] Mep12 ticks and spines Mar 7, 2017

@QuLogic

QuLogic approved these changes Mar 7, 2017
View changes

QuLogic changed the title from [MRG] Mep12 ticks and spines to [MRG+1] Mep12 ticks and spines Mar 7, 2017

examples/ticks_and_spines/spines_demo.py
+ax2.plot(x, y)
+
+# Only draw spine between the y-ticks
+ax2.spines['left'].set_bounds(-1, 1)
@tacaswell

tacaswell Mar 7, 2017

Owner

Well, I learned something...

tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 7, 2017

@tacaswell
Owner

tacaswell commented Mar 7, 2017

Please backport to 2.0.0-doc

QuLogic added the Documentation label Mar 7, 2017

NelleV changed the title from [MRG+1] Mep12 ticks and spines to [MRG+2] Mep12 ticks and spines Mar 7, 2017

examples/ticks_and_spines/spines_demo.py
+Spines
+======
+
+This demo compares :
@anntzer

anntzer Mar 7, 2017

Contributor

no space before the colon (English typography :-))

examples/ticks_and_spines/spines_demo.py
+======
+
+This demo compares :
+ - normal axes, with spines on all four sides
@anntzer

anntzer Mar 7, 2017

Contributor

Add dots (or commas) at the end of each item.

examples/ticks_and_spines/spines_demo.py
@@ -26,7 +30,18 @@
ax1.yaxis.set_ticks_position('left')
ax1.xaxis.set_ticks_position('bottom')
+
@anntzer

anntzer Mar 7, 2017

Contributor

no need for two empty lines? (there's only one between ax0 and ax1)

examples/ticks_and_spines/tick-locators.py
+=============
+Tick locators
+=============
+
Show the different tick locators
@anntzer

anntzer Mar 7, 2017

Contributor

Add a dot.

@NelleV NelleV DOC fixe small typos and blank lines

All checks have failed

2 errored checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
1d89c92
@NelleV
Contributor

NelleV commented Mar 7, 2017

I fixed the blank spaces/lines issues.
@anntzer

anntzer requested changes Mar 7, 2017
View changes

just being finicky...

examples/ticks_and_spines/spines_demo.py
+This demo compares:
+ - normal axes, with spines on all four sides;
+ - an axes with spines only on the left and bottom;
+ - an axes using custom bounds to limit the extent of the spine;
@anntzer

anntzer Mar 7, 2017

Contributor

not at the end of the last item...

@NelleV

NelleV Mar 7, 2017

Contributor

As a side note, when it starts being that nitpicky, it is much faster to fix it yourself before merging.

@NelleV

NelleV Mar 7, 2017

Contributor

FYI, I didn't even bother doing it on my computer: I just did it through the github API.

@anntzer

anntzer Mar 7, 2017

Contributor

Ah, I didn't know I could do it directly there... good point.

@NelleV NelleV Update spines_demo.py

All checks have failed

2 errored checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
df511a5
@anntzer

anntzer approved these changes Mar 7, 2017
View changes

@anntzer anntzer merged commit b2137d7 into matplotlib:master Mar 7, 2017
0 of 2 checks passed

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@anntzer
Contributor

anntzer commented Mar 7, 2017

Thanks.

anntzer changed the title from [MRG+2] Mep12 ticks and spines to Mep12 ticks and spines Mar 7, 2017

QuLogic added the Needs backport label Mar 7, 2017

QuLogic referenced this pull request Mar 7, 2017

Closed

need to backport docathon PRs #8223

dstansby added the MEP12 label Mar 25, 2017

@dstansby dstansby added a commit that referenced this pull request Mar 25, 2017

@anntzer @dstansby anntzer + dstansby Merge pull request #8212 from NelleV/MEP12_ticks_and_spines 
Mep12 ticks and spines
 6750f68
@dstansby
Contributor

dstansby commented Mar 25, 2017

Backported to 2.0.0-doc via. 6750f68

dstansby removed the Needs backport label Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment