Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Early check for dot binary (from graphviz) when building the doc (fixes #8207) #8221
Conversation
afvincent
added the
Documentation
label
Mar 7, 2017
afvincent
added this to the
2.0.1 (next bug fix release)
milestone
Mar 7, 2017
NelleV
changed the title from
Early check for dot binary (from graphviz) when building the doc (fixes #8207) to [MRG+1] Early check for dot binary (from graphviz) when building the doc (fixes #8207)
Mar 7, 2017
|
It also look good to me, though the amount of dependencies we have in our documentation worries me. It means that new contributors struggle with something as simple as contributing documentation. |
NelleV
changed the title from
[MRG+1] Early check for dot binary (from graphviz) when building the doc (fixes #8207) to [MRG+2] Early check for dot binary (from graphviz) when building the doc (fixes #8207)
Mar 7, 2017
|
@NelleV I wonder whether we could create two mpl-testing and mpl-docs packages on conda-forge which would pull in all required dependencies, including the non-python ones (for example, graphviz is packaged by conda). Then the instructions would just be to install the corresponding package from conda. |
|
@anntzer I don't use conda, so I have no opinion on whether this would be useful. An option would be to change the default for allowsphinxwarnings so that people can build the documentation with missing dependencies. That would reduce the barrier for contributions, but then it would be up to us (core contributors) to guide new contributors on fixing travis build. I do not think we are well equipped for that option. |
|
Alternatively, I know that imageio has been including code to download ffmpeg/avbin/freeimage at runtime (http://imageio.readthedocs.io/en/latest/envvariables.html), so that could be an option too (although it would certainly have its own issues, unless they have completely statically linked builds...). |
NelleV
merged commit bb167dd
into matplotlib:master
Mar 8, 2017
5 checks passed
|
Thanks @afvincent ! |
afvincent
deleted the
afvincent:doc_early_check_for_dot branch
Mar 8, 2017
QuLogic
added the
Needs backport
label
Mar 20, 2017
QuLogic
changed the title from
[MRG+2] Early check for dot binary (from graphviz) when building the doc (fixes #8207) to Early check for dot binary (from graphviz) when building the doc (fixes #8207)
Mar 20, 2017
dstansby
added a commit
that referenced
this pull request
Mar 25, 2017
|
|
NelleV + dstansby |
c8b4db8
|
|
Backported to |
afvincent commentedMar 7, 2017
Fixes #8207.
The commit is shamelessly inspired from #8213.