Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Implement Path.intersects_bbox in C++ to speed up legend positioning. #8224
+1,810
−7
Conversation
|
MaartenBaert |
All checks have passed |
c814beb
|
MaartenBaert
referenced
this pull request
Mar 7, 2017
Closed
Faster legend with location 'best' #8126
| +(the default value), there is no change in behavior. For those rare cases where | ||
| +``Path.intersects_bbox`` was called with ``filled`` set to ``False`` and where | ||
| +the old behavior is actually desired, the suggested workaround is to call | ||
| +``Path.intersects_path`` with a rectangle as the path: |
anntzer
Mar 7, 2017
Contributor
I think you need to end the paragraph with two colons (::) so that what follows is treated as a code block.
You can just commit --amend and force push.
anntzer
Mar 7, 2017
Contributor
I will edit this myself after Appveyor passes (it is actually important for this PR), and skip the rebuild.
anntzer
merged commit 2fd6129
into matplotlib:master
Mar 8, 2017
|
Thanks for this very useful contribution. |
|
That PR uses functions that don't exist anymore. |
|
or I need to rebuild my c code :) |
QuLogic
added this to the
2.1 (next point release)
milestone
Mar 9, 2017
ibnIrshad
referenced
this pull request
Mar 9, 2017
Open
Default legend location 'best' is extremely slow #8108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MaartenBaert commentedMar 7, 2017
Squashed version of PR #8126.