MEP12 text alignment example #8228

Merged
merged 3 commits into from Mar 8, 2017

Conversation

Projects
None yet
5 participants
Contributor

dstansby commented Mar 7, 2017

Another documentation update!

dstansby added some commits Mar 7, 2017

@dstansby dstansby MEP12 alignment_test 5670b0a
@dstansby dstansby Move alignment_test example
97068eb
@NelleV

NelleV approved these changes Mar 7, 2017

LGTM!
Thanks @dstansby

NelleV changed the title from MEP12 text alignment example to [MRG+1] MEP12 text alignment example Mar 7, 2017

@@ -47,24 +49,24 @@
verticalalignment='top',
transform=ax.transAxes)
-ax.text(left, 0.5*(bottom + top), 'right center',
+ax.text(left, 0.5 * (bottom + top), 'right center',
@thisch

thisch Mar 7, 2017

Contributor

I'm -1 on this and the following changes. Note that PEP8 AFAIK does not recommend to add whitespace before and after this operator.

@thisch

thisch Mar 7, 2017

Contributor

It says 'Use your own judgment;'

@anntzer

anntzer Mar 7, 2017

Contributor

"If operators with different priorities are used, consider adding whitespace around the operators with the lowest priority(ies)."

@thisch

thisch Mar 12, 2017

Contributor

In the above line the operator with the lowest priority is the plus operator around which whitespace is added. PEP8 does not say anything about adding whitespace to all operators independent of their priorities.

@anntzer

feel free to dismiss the review if "to" is more colloquial

You can precisely layout text in data or axes (0,1) coordinates. This
example shows you some of the alignment and rotation specifications to
-layout text
+layout text.
@anntzer

anntzer Mar 7, 2017

Contributor

"for layout text"? (nonnative speaker here)

@QuLogic

QuLogic Mar 7, 2017

Member

"for text layout"

@dstansby dstansby Clean up description wording
27c9686

@anntzer anntzer merged commit 355695a into matplotlib:master Mar 8, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Contributor

anntzer commented Mar 8, 2017

Thanks!

anntzer changed the title from [MRG+1] MEP12 text alignment example to MEP12 text alignment example Mar 8, 2017

dstansby deleted the dstansby:alignment-example branch Mar 8, 2017

QuLogic added this to the 2.1 (next point release) milestone Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment