/matplotlib

changes to MEP12/sphinx-gallery compliant #8233

Merged
merged 2 commits into from Mar 8, 2017

Conversation

Reviewers

@NelleV NelleV

@anntzer anntzer

Assignees
No one assigned
Labels
None yet
Projects

Merged PRs in Documentation overhaul

Milestone
  v2.0.1
4 participants
@mnegus01 @anntzer @dstansby @NelleV
@mnegus01
Contributor

mnegus01 commented Mar 8, 2017

In response to #7206; similar to #8209

mnegus01 added some commits Mar 8, 2017

@mnegus01 mnegus01 added headers 856b747
@mnegus01 mnegus01 added/fixed headers

All checks have failed

2 errored checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
db8daaf
@NelleV

NelleV approved these changes Mar 8, 2017
View changes

LGTM 👍
Thanks!

examples/mplot3d/pathpatch3d_demo.py
+import numpy as np
@NelleV

NelleV Mar 8, 2017

Contributor

I wonder how this example even ran without numpy…

@anntzer

anntzer Mar 8, 2017

Contributor

It did not, so the question is, why was it not picked up by the gallery?

@anntzer

anntzer Mar 8, 2017

Contributor

http://matplotlib.org/devdocs/examples/mplot3d/pathpatch3d_demo.html super confused now.

@NelleV

NelleV Mar 8, 2017

Contributor

That is super wierd…

@anntzer

anntzer Mar 8, 2017

Contributor

Can you open an issue to track this?

NelleV changed the title from changes to MEP12/sphinx-gallery compliant to [MRG+1] changes to MEP12/sphinx-gallery compliant Mar 8, 2017

@anntzer anntzer merged commit ddc9976 into matplotlib:master Mar 8, 2017
0 of 2 checks passed

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@anntzer
Contributor

anntzer commented Mar 8, 2017

Thanks!

anntzer referenced this pull request Mar 8, 2017

Closed

need to backport docathon PRs #8223

QuLogic changed the title from [MRG+1] changes to MEP12/sphinx-gallery compliant to changes to MEP12/sphinx-gallery compliant Mar 8, 2017

@dstansby
Contributor

dstansby commented Mar 8, 2017

I know everyone is keen to merge doc related pull requests, but please wait until at least the documentation build and PEP8 build on travis are complete before merging.

It turns out this PR had a PEP8 violation that went by un-noticed.

dstansby referenced this pull request Mar 8, 2017

Merged

Fix pep8 violation #8237

@anntzer
Contributor

anntzer commented Mar 8, 2017

Apologies.

mnegus01 referenced this pull request Mar 22, 2017

Closed

All examples should be MEP12/sphinx-gallery compliant #7206

57 of 361 tasks complete

story645 added to Merged PRs in Documentation overhaul Apr 14, 2017

@dstansby dstansby added a commit that referenced this pull request Apr 30, 2017

@anntzer @dstansby anntzer + dstansby Merge pull request #8233 from mnegus01/MEP12_comp1 
[MRG+1] changes to MEP12/sphinx-gallery compliant
 1641eab

dstansby added this to the 2.0.1 (next bug fix release) milestone Apr 30, 2017

@dstansby
Contributor

dstansby commented Apr 30, 2017

Backported to 2.0.x via. 1641eab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment