New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort input files #8747

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
6 participants
@bmwiedemann
Contributor

bmwiedemann commented Jun 12, 2017

when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would usually differ.

See https://reproducible-builds.org/ for why this matters.

sort input files
when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would usually differ.

See https://reproducible-builds.org/ for why this matters.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jun 12, 2017

@tacaswell tacaswell added the build label Jun 12, 2017

@WeatherGod

This comment has been minimized.

Show comment
Hide comment
@WeatherGod

WeatherGod Jun 12, 2017

Member

There is the same error in two of the CI builds. I restarted them, but I don't know if that'll make a difference. The errors are not one of the usual transient ones.

Member

WeatherGod commented Jun 12, 2017

There is the same error in two of the CI builds. I restarted them, but I don't know if that'll make a difference. The errors are not one of the usual transient ones.

@jenshnielsen

This comment has been minimized.

Show comment
Hide comment
@jenshnielsen

jenshnielsen Jun 12, 2017

Member

I guess it's the error fixed by #8737

Member

jenshnielsen commented Jun 12, 2017

I guess it's the error fixed by #8737

@dstansby

This comment has been minimized.

Show comment
Hide comment
@dstansby

dstansby Jun 12, 2017

Contributor

Yep, I think CI is broken unless someone puts in a PR to force numpy!=1.13 to be installed or #8737 is merged.

Contributor

dstansby commented Jun 12, 2017

Yep, I think CI is broken unless someone puts in a PR to force numpy!=1.13 to be installed or #8737 is merged.

@QuLogic QuLogic merged commit 545af7a into matplotlib:master Jun 12, 2017

6 checks passed

codecov/patch Coverage not affected when comparing aec1e5b...88f037b
Details
codecov/project/library 60.68% (target 50%)
Details
codecov/project/tests 98.78% (+0.44%) compared to aec1e5b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@bmwiedemann bmwiedemann deleted the bmwiedemann:sort branch Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment