Miscelaneous, uninteresting whitespace & docstring fixes. #910
Conversation
|
Great. Large parts of the codebase predate PEP8, but it would be sure nice to bring this into the present day. However, big whitespace changes like this make merging and comparing branches more difficult. I'd prefer we hold off on this until after the 1.1.2 release is made (and the 1.1.x branch is subsequently abandoned), because then we'll have a more linear development model. |
|
This includes one genuine bug fix which should go in 1.1.x, however: the change in ticker.py of "positive" to "positive_sign". |
|
@efiring: Good point. Let's get that bugfix on v1.1.x -- probably doesn't need a PR of its own. |
|
Closed for #911 |
|
I wouldn't necessarily close this -- just postpone it for after the next 1.1.x release... Or is there another good reason to close it? |
|
There's no good reason other than a bit of housekeeping. I'm tempted to write some code/regexes to automate the process of fixing the whitespace, and then apply it to the whole mpl codebase (once the 1.1.x line is free from active changes). |
* upstream/v1.1.x: Pass ints to Tk.Canvas.create_image Backport #920 to the v1.1.x branch Add info about installing from source using Pip. Closes #646. Fixed string concatenation. . Ported fix from #910 Install the mpltest.ttf file Remove PNG from the test_ttconv test -- it doesn't seem to work across freetype versions, and also it doesn't actually test ttconv, wihch is not used by the Agg backend. Move test font inside test directory Add a test case for ttconv Fix TrueType to Type-3 font conversion Fix bug when resizing qt4 figure window.
When reading through code to understand certain capabilities, I tend to fix up the whitespace, by hand, to be more PEP8 conformant/readable. These are some of those changes.
I feel that these changes improve readability, but I won't be disheartened if it is decided not to merge into master.