Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated features for 2.2 #9316

Merged
merged 6 commits into from Dec 26, 2017

Conversation

Projects
None yet
4 participants
@anntzer
Copy link
Contributor

commented Oct 8, 2017

PR Summary

Time to kill more code... I had this ready for a while :-)

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby dstansby added this to the 2.2 (next feature release) milestone Oct 8, 2017

@anntzer anntzer force-pushed the anntzer:apichanges-22 branch from ae87752 to 439d0a3 Nov 4, 2017

@dstansby

This comment has been minimized.

Copy link
Contributor

commented Nov 4, 2017

Maybe needs a rebase to get CircleCI to pass?

@anntzer anntzer force-pushed the anntzer:apichanges-22 branch from 439d0a3 to b8aabc1 Nov 4, 2017

@anntzer

This comment has been minimized.

Copy link
Contributor Author

commented Nov 4, 2017

just some broken links to removed stuff

@anntzer anntzer force-pushed the anntzer:apichanges-22 branch from b8aabc1 to 8664f7b Nov 4, 2017

@dstansby
Copy link
Contributor

left a comment

All looks good to me, though someone whose been working with MPL a bit longer than me should check.

Removal of deprecated features
``````````````````````````````

The ``matplotlib.finance``, ``mpl_toolkits.exceltools`` and

This comment has been minimized.

Copy link
@dstansby

dstansby Nov 5, 2017

Contributor

Is the finance toolkit now in another package?

This comment has been minimized.

Copy link
@anntzer

anntzer Nov 5, 2017

Author Contributor

done


The ``bgcolor`` keyword argument to ``Axes`` has been removed.

The ``spectral`` and ``Vega*`` colormaps have been removed.

This comment has been minimized.

Copy link
@dstansby

dstansby Nov 5, 2017

Contributor

Vega got renamed right? Might be worth mentioning that here.

This comment has been minimized.

Copy link
@anntzer

anntzer Nov 5, 2017

Author Contributor

done

@anntzer anntzer force-pushed the anntzer:apichanges-22 branch from 8664f7b to 083bb43 Nov 5, 2017

@anntzer anntzer force-pushed the anntzer:apichanges-22 branch from 083bb43 to 5a3054a Nov 13, 2017

anntzer added some commits Sep 22, 2017

Remove mencoder support.
Also removed movie_demo_sgskip, which was broken anyways (it did not
import os); moviewrite_sgskip, which uses the animation API is a better
example anyways (I don't think there's much of a point to show the flags
for a specific encoder in an example -- if anything, that should go to
the class docstring).

@anntzer anntzer force-pushed the anntzer:apichanges-22 branch from 5a3054a to 68c31d7 Dec 26, 2017

@dstansby
Copy link
Contributor

left a comment

👍 thanks for all the work that's gone into this! I think it would be good to get in as soon as possible so have a while to spot any issues before 2.2 is released.

@tacaswell tacaswell merged commit 57daa4d into matplotlib:master Dec 26, 2017

5 checks passed

ci/circleci: docs-python27 Your tests passed on CircleCI!
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@anntzer anntzer deleted the anntzer:apichanges-22 branch Dec 26, 2017

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.