Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If PIL.image is missing, tell user to install pillow #9365

Merged
merged 2 commits into from Oct 13, 2017

Conversation

Projects
None yet
5 participants
@dstansby
Copy link
Contributor

commented Oct 11, 2017

If pillow isn't installed and one tries to build the docs, currently the error message is

ImportError: The following dependencies are missing to build the documentation: PIL.Image

It took me a while and a bit of searching that to fix this requires installing the pillow package. This PR changes the error message to

ImportError: The following dependencies are missing to build the documentation: pillow

to make it much clearer which package is missing and needs to be installed.

doc/conf.py Outdated
@@ -55,7 +55,10 @@ def _check_deps():
try:
__import__(name)
except ImportError:
missing.append(name)
if name == 'PIL.Image':

This comment has been minimized.

Copy link
@anntzer

anntzer Oct 11, 2017

Contributor

just make names a mapping? IPython.blah.blah is likewise technically not the correct name (should be just IPython).

@dstansby dstansby force-pushed the dstansby:doc-build-reqs branch from 802ed1f to cb94229 Oct 11, 2017

@jklymak

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

👍 on this. Every six months or so I went through this! conda install PIL, pip install PIL, google google google.... oh, conda install pillow.

@anntzer
Copy link
Contributor

left a comment

conditional on tests passing (but why would they not)

@jklymak

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2017

... yet docs-python27 failed for some reason. :-(

@anntzer

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2017

Because names.append("mock").

@dstansby

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2017

Does that mean the other append statement won't work on python 2 either?

@anntzer

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2017

... no? missing is a list.

@tacaswell tacaswell merged commit bcf269e into matplotlib:master Oct 13, 2017

7 of 8 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: docs-python27 Your tests passed on CircleCI!
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 95805d2...5fa465e
Details
codecov/project/library 61.32% (target 50%)
Details
codecov/project/tests 98.72% remains the same compared to 95805d2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@QuLogic QuLogic added this to the 2.2 (next feature release) milestone Oct 13, 2017

@dstansby dstansby deleted the dstansby:doc-build-reqs branch Oct 22, 2017

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.