Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute users/intro to JDH and rename to history. #9515

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
4 participants
@anntzer
Copy link
Contributor

commented Oct 22, 2017

Just in case anyone is wondering for the trademarks:
the signs are clearly not necessary, see e.g.
https://academia.stackexchange.com/a/61852

git blame points to f0f28a3 as origin of the text.

Closes #9348.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Attribute users/intro to JDH and rename to history.
Just in case anyone is wondering for the trademarks:
the signs are clearly not necessary, see e.g.
https://academia.stackexchange.com/a/61852

@tacaswell tacaswell added this to the v2.1.0-doc milestone Oct 22, 2017

@@ -12,7 +12,7 @@ User's Guide
.. toctree::
:maxdepth: 2

intro.rst
history.rst

This comment has been minimized.

Copy link
@Kojoley

Kojoley Oct 28, 2017

Member

I am not familiar with guide writing but it seems odd to me that user guide starts with a history chapter.

This comment has been minimized.

Copy link
@anntzer

anntzer Oct 28, 2017

Author Contributor

I don't think many people read the docs in linear order tbh

@efiring
Copy link
Member

left a comment

The standard for documentation is "substantially improved", and I think this meets that standard.

@tacaswell tacaswell merged commit 82b65c2 into matplotlib:master Oct 29, 2017

8 checks passed

ci/circleci: docs-python27 Your tests passed on CircleCI!
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 201d536...192b26b
Details
codecov/project/library 61.41% (target 50%)
Details
codecov/project/tests 98.72% remains the same compared to 201d536
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

meeseeksdev bot pushed a commit that referenced this pull request Oct 29, 2017

@anntzer anntzer deleted the anntzer:jdh-intro branch Oct 29, 2017

anntzer added a commit that referenced this pull request Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.